[builtins] Introduce new TFC macro and auto-generate TFS descriptors

[builtins] Introduce new TFC macro and auto-generate TFS descriptors

Split TFS builtins into

* TFC: TF builtins with stub linkage that use a custom interface descriptor
       (e.g. because of a non-standard return size or untagged arguments)
* TFS: the rest.

Automatically generate interface descriptors for TFS builtins to reduce
boilerplate involved in setting up stub calls. These are now as simple as
creating the TFS stub and using CSA::CallBuiltin, no extra work required.

BUG=v8:6116
Review-Url: https://codereview.chromium.org/2777203007
Cr-Commit-Position: refs/heads/master@{#44490}
Committed: https://chromium.googlesource.com/v8/v8/+/9ddfeafe94833bcb64a3dad8e3cf0cf65239af21

[jgruber, 2017-03-29 09:44:31]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:45:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-29 09:50:08]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-29 09:52:18]

jgruber@chromium.org changed reviewers:
+ ishell@chromium.org

[jgruber, 2017-03-29 09:52:18]

Hey Igor, PTAL. 

The gist is that interface descriptors for TFS builtins are now automatically
generated in interface-descriptors.h.

In a follow-up we can remove unneeded CodeFactory functions.

[commit-bot: I haz the power, 2017-03-29 10:14:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 10:14:10]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-04-04 09:05:43]

lgtm

https://codereview.chromium.org/2777203007/diff/20001/src/builtins/builtins-d...
File src/builtins/builtins-definitions.h (right):

https://codereview.chromium.org/2777203007/diff/20001/src/builtins/builtins-d...
src/builtins/builtins-definitions.h:40: //      Args: name, interface
descriptor, return_size
It looks like the result size should be a part of call interface descriptor.

[jgruber, 2017-04-07 08:41:11]

Thanks for the review, I'll get started with rebasing.

https://codereview.chromium.org/2777203007/diff/20001/src/builtins/builtins-d...
File src/builtins/builtins-definitions.h (right):

https://codereview.chromium.org/2777203007/diff/20001/src/builtins/builtins-d...
src/builtins/builtins-definitions.h:40: //      Args: name, interface
descriptor, return_size
On 2017/04/04 09:05:43, Igor Sheludko wrote:
> It looks like the result size should be a part of call interface descriptor.

Acknowledged. Let's take that on in a separate CL.

[jgruber, 2017-04-07 14:02:09]

Description was changed from

==========
[builtins] Introduce new TFC macro and auto-generate TFS descriptors

Split TFS builtins into

* TFC: TF builtins with stub linkage that use a custom interface descriptor
       (e.g. because of a non-standard return size or untagged arguments)
* TFS: the rest.

Automatically generate interface descriptors for TFS builtins to reduce
boilerplate involved in setting up stub calls.

BUG=v8:6116
==========

to

==========
[builtins] Introduce new TFC macro and auto-generate TFS descriptors

Split TFS builtins into

* TFC: TF builtins with stub linkage that use a custom interface descriptor
       (e.g. because of a non-standard return size or untagged arguments)
* TFS: the rest.

Automatically generate interface descriptors for TFS builtins to reduce
boilerplate involved in setting up stub calls. These are now as simple as
creating the TFS stub and using CSA::CallBuiltin, no extra work required.

BUG=v8:6116
==========

[jgruber, 2017-04-07 15:16:45]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 15:16:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-07 15:20:56]

On 2017/04/07 08:41:11, jgruber wrote:
> Thanks for the review, I'll get started with rebasing.
> 
>
https://codereview.chromium.org/2777203007/diff/20001/src/builtins/builtins-d...
> File src/builtins/builtins-definitions.h (right):
> 
>
https://codereview.chromium.org/2777203007/diff/20001/src/builtins/builtins-d...
> src/builtins/builtins-definitions.h:40: //      Args: name, interface
> descriptor, return_size
> On 2017/04/04 09:05:43, Igor Sheludko wrote:
> > It looks like the result size should be a part of call interface descriptor.
> 
> Acknowledged. Let's take that on in a separate CL.

Rebased on top of recent changes (builtins generation in snapshot, promise and
async-iteration). Landing if tests go green.

[commit-bot: I haz the power, 2017-04-07 15:40:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 15:40:06]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-04-07 15:40:30]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-04-07 15:40:30]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2777203007/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-07 15:40:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 15:42:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491579630442600,
"parent_rev": "5f9af1e7b56846950f134a198d150822e75337b6", "commit_rev":
"9ddfeafe94833bcb64a3dad8e3cf0cf65239af21"}

[commit-bot: I haz the power, 2017-04-07 15:42:27]

Description was changed from

==========
[builtins] Introduce new TFC macro and auto-generate TFS descriptors

Split TFS builtins into

* TFC: TF builtins with stub linkage that use a custom interface descriptor
       (e.g. because of a non-standard return size or untagged arguments)
* TFS: the rest.

Automatically generate interface descriptors for TFS builtins to reduce
boilerplate involved in setting up stub calls. These are now as simple as
creating the TFS stub and using CSA::CallBuiltin, no extra work required.

BUG=v8:6116
==========

to

==========
[builtins] Introduce new TFC macro and auto-generate TFS descriptors

Split TFS builtins into

* TFC: TF builtins with stub linkage that use a custom interface descriptor
       (e.g. because of a non-standard return size or untagged arguments)
* TFS: the rest.

Automatically generate interface descriptors for TFS builtins to reduce
boilerplate involved in setting up stub calls. These are now as simple as
creating the TFS stub and using CSA::CallBuiltin, no extra work required.

BUG=v8:6116

Review-Url: https://codereview.chromium.org/2777203007
Cr-Commit-Position: refs/heads/master@{#44490}
Committed:
https://chromium.googlesource.com/v8/v8/+/9ddfeafe94833bcb64a3dad8e3cf0cf6523...
==========

[commit-bot: I haz the power, 2017-04-07 15:42:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/9ddfeafe94833bcb64a3dad8e3cf0cf6523...

[Benedikt Meurer, 2017-04-10 05:52:36]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-04-10 05:52:36]

This was quite surprising to discover in the morning. Some general heads-up
before landing these changes would be nice in the future. This broke existing
CLs in flight. Why didn't we keep TFS the way it was and just introduced a new
one for the auto-generate magic?

[jgruber, 2017-04-10 07:07:18]

On 2017/04/10 05:52:36, Benedikt Meurer wrote:
> This was quite surprising to discover in the morning. Some general heads-up
> before landing these changes would be nice in the future. This broke existing
> CLs in flight. Why didn't we keep TFS the way it was and just introduced a new
> one for the auto-generate magic?

Sorry for the additional rebasing work, I'll announce on the list. The decision
between
TFS/TFC was fairly arbitrary: TFS is intended to be the standard builtin type,
TFC the custom
one.