Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2784783002: DNS: Testing for [blink] Support (semi-)transparent background colors.

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, nasko+codewatch_chromium.org, eae+blinkwatch, fs, dcheng, apavlov+blink_chromium.org, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, caseq+blink_chromium.org, krit, szager+layoutwatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, rwlbuis, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, dshwang, creis+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, devtools-reviews_chromium.org, lushnikov+blink_chromium.org, piman+watch_chromium.org, Stephen Chennney, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, fmalita+watch_chromium.org, pfeldman+blink_chromium.org, blink-reviews-frames_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DNS: Testing for [blink] Support (semi-)transparent background colors. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 : test with hasAlpha instead of alpha > 0 #

Patch Set 2 : test without FullscreenController transparency #

Patch Set 3 : test with !hasAlpha instead of alpha > 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -140 lines) Patch
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 3 chunks +6 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ViewPainter.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.h View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 2 5 chunks +25 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 4 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 10 chunks +38 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 8 chunks +17 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayerTreeView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameWidget.h View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (14 generated)
Eric Seckler
Description was changed from ========== DNS: Testing for [blink] Support (semi-)transparent background colors. BUG= ========== ...
3 years, 8 months ago (2017-03-29 08:31:31 UTC) #1
Eric Seckler
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-29 08:35:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784783002/1
3 years, 8 months ago (2017-03-29 08:35:55 UTC) #3
Eric Seckler
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-29 09:03:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784783002/20001
3 years, 8 months ago (2017-03-29 09:03:43 UTC) #5
Eric Seckler
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-29 09:06:05 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784783002/40001
3 years, 8 months ago (2017-03-29 09:06:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-29 09:16:52 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/236899) mac_chromium_compile_dbg_ng on ...
3 years, 8 months ago (2017-03-29 09:16:53 UTC) #9
Eric Seckler
Patchset #3 (id:40001) has been deleted
3 years, 8 months ago (2017-03-29 09:33:19 UTC) #10
Eric Seckler
The CQ bit was checked by eseckler@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-29 09:33:27 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784783002/60001
3 years, 8 months ago (2017-03-29 09:33:46 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-29 10:35:05 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 10:35:05 UTC) #14 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698