third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp - Issue 2784783002: DNS: Testing for [blink] Support (semi-)transparent background colors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

Issue 2784783002: DNS: Testing for [blink] Support (semi-)transparent background colors.

Patch Set: test with !hasAlpha instead of alpha > 0 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

index b45fdf9805fb586f6975e130889f4542721d170f..70d804296274d4459ef2f79d8dd4eb11c2910d16 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

@@ -24,7 +24,7 @@ LocalFrame* SingleChildLocalFrameClient::createFrame(

LocalFrame* parentFrame = ownerElement->document().frame();

auto* childClient = LocalFrameClientWithParent::create(parentFrame);

m_child = LocalFrame::create(childClient, *parentFrame->page(), ownerElement);

- m_child->createView(IntSize(500, 500), Color(), true /* transparent */);

+ m_child->createView(IntSize(500, 500), Color::transparent);

m_child->init();

return m_child.get();