Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2784783002: DNS: Testing for [blink] Support (semi-)transparent background colors.
Patch Set: test with !hasAlpha instead of alpha > 0 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 309
310 provideContextFeaturesTo(*m_page, WTF::makeUnique<PagePopupFeaturesClient>()); 310 provideContextFeaturesTo(*m_page, WTF::makeUnique<PagePopupFeaturesClient>());
311 DEFINE_STATIC_LOCAL(LocalFrameClient, emptyLocalFrameClient, 311 DEFINE_STATIC_LOCAL(LocalFrameClient, emptyLocalFrameClient,
312 (EmptyLocalFrameClient::create())); 312 (EmptyLocalFrameClient::create()));
313 LocalFrame* frame = LocalFrame::create(&emptyLocalFrameClient, *m_page, 0); 313 LocalFrame* frame = LocalFrame::create(&emptyLocalFrameClient, *m_page, 0);
314 frame->setPagePopupOwner(m_popupClient->ownerElement()); 314 frame->setPagePopupOwner(m_popupClient->ownerElement());
315 frame->setView(FrameView::create(*frame)); 315 frame->setView(FrameView::create(*frame));
316 frame->init(); 316 frame->init();
317 frame->view()->setParentVisible(true); 317 frame->view()->setParentVisible(true);
318 frame->view()->setSelfVisible(true); 318 frame->view()->setSelfVisible(true);
319 frame->view()->setTransparent(false);
320 if (AXObjectCache* cache = 319 if (AXObjectCache* cache =
321 m_popupClient->ownerElement().document().existingAXObjectCache()) 320 m_popupClient->ownerElement().document().existingAXObjectCache())
322 cache->childrenChanged(&m_popupClient->ownerElement()); 321 cache->childrenChanged(&m_popupClient->ownerElement());
323 322
324 DCHECK(frame->domWindow()); 323 DCHECK(frame->domWindow());
325 PagePopupSupplement::install(*frame, *this, m_popupClient); 324 PagePopupSupplement::install(*frame, *this, m_popupClient);
326 DCHECK_EQ(m_popupClient->ownerElement().document().existingAXObjectCache(), 325 DCHECK_EQ(m_popupClient->ownerElement().document().existingAXObjectCache(),
327 frame->document()->existingAXObjectCache()); 326 frame->document()->existingAXObjectCache());
328 327
329 initializeLayerTreeView(); 328 initializeLayerTreeView();
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
591 // A WebPagePopupImpl instance usually has two references. 590 // A WebPagePopupImpl instance usually has two references.
592 // - One owned by the instance itself. It represents the visible widget. 591 // - One owned by the instance itself. It represents the visible widget.
593 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 592 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
594 // WebPagePopupImpl to close. 593 // WebPagePopupImpl to close.
595 // We need them because the closing operation is asynchronous and the widget 594 // We need them because the closing operation is asynchronous and the widget
596 // can be closed while the WebViewImpl is unaware of it. 595 // can be closed while the WebViewImpl is unaware of it.
597 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 596 return adoptRef(new WebPagePopupImpl(client)).leakRef();
598 } 597 }
599 598
600 } // namespace blink 599 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698