third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2784783002: DNS: Testing for [blink] Support (semi-)transparent background colors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2784783002: DNS: Testing for [blink] Support (semi-)transparent background colors.

Patch Set: test with !hasAlpha instead of alpha > 0 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index 7a229f3c9a29299a7b7e9ae5f6b2f48c1776aa80..b3067979eb1c386f5cc4135a1063fc0db12c6cb2 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -434,12 +434,12 @@ TEST_P(WebViewTest, SetBaseBackgroundColor) {

frame->document()->shutdown();

// Creating a new frame view with the background color having 0 alpha.

- frame->createView(IntSize(1024, 768), Color::transparent, true);

+ frame->createView(IntSize(1024, 768), Color::transparent);

EXPECT_EQ(kTransparent, frame->view()->baseBackgroundColor());

frame->view()->dispose();

const Color transparentRed(100, 0, 0, 0);

- frame->createView(IntSize(1024, 768), transparentRed, true);

+ frame->createView(IntSize(1024, 768), transparentRed);

EXPECT_EQ(transparentRed, frame->view()->baseBackgroundColor());

frame->view()->dispose();

}