DevTools: prepare tests for Persistence2.0 release

DevTools: prepare tests for Persistence2.0 release

We have a bunch of tests which rely on DefaultMapping to test
Persistence layer. However, they don't test the DefaultMapping
behavior - instead, they want to test the Persistence layer and everyone
who depends on it.

This patch:
- adds a simple TestMapping which controllably adds and removes persistence
  bindings
- moves majority of the tests over to TestMapping
- removes a few tests which were testing themselves

This is a pre-step to enable Persistence2.0.

BUG=277885
R=dgozman

Review-Url: https://codereview.chromium.org/2784733002
Cr-Commit-Position: refs/heads/master@{#460466}
Committed: https://chromium.googlesource.com/chromium/src/+/6b74f6642be4ca9d5af4de7dcc56ea58c3f62e53

[lushnikov, 2017-03-28 22:42:10]

please, take a look

[lushnikov, 2017-03-28 22:42:22]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 22:42:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-03-28 22:44:01]

Description was changed from

==========
DevTools: prepare tests for Persistence2.0 release

We have a bunch of tests which rely on DefaultMapping to test
Persistence layer. However, they don't test the DefaultMapping
behavior - instead, they want to test the Persistence layer and everyone
who depends on it.

This patch adds a simple TestMapping which controllably adds and removes
persistence
bindings. It also removes majority of the tests over to this
implementation.

BUG=277885
R=dgozman
==========

to

==========
DevTools: prepare tests for Persistence2.0 release

We have a bunch of tests which rely on DefaultMapping to test
Persistence layer. However, they don't test the DefaultMapping
behavior - instead, they want to test the Persistence layer and everyone
who depends on it.

This patch:
- adds a simple TestMapping which controllably adds and removes persistence
  bindings
- moves majority of the tests over to TestMapping
- removes a few tests which were testing themselves

This is a pre-step to enable Persistence2.0.

BUG=277885
R=dgozman
==========

[dgozman, 2017-03-28 22:51:20]

lgtm

https://codereview.chromium.org/2784733002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
(right):

https://codereview.chromium.org/2784733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:68:
throw new Error(`FAILED TO ADD BINDING: binding already exists for
${urlSuffix}`);
InspectorTest.addResult + completeTest instead to not timeout?

https://codereview.chromium.org/2784733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:88:
throw new Error(`FAILED TO REMOVE BINDING: binding does not exist for
${urlSuffix}`);
ditto

[lushnikov, 2017-03-28 23:11:28]

All done. Also, fixed the last three tests which hardly require DefaultMapping.
Please, take another look

https://codereview.chromium.org/2784733002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
(right):

https://codereview.chromium.org/2784733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:68:
throw new Error(`FAILED TO ADD BINDING: binding already exists for
${urlSuffix}`);
On 2017/03/28 22:51:20, dgozman wrote:
> InspectorTest.addResult + completeTest instead to not timeout?

Done.

https://codereview.chromium.org/2784733002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:88:
throw new Error(`FAILED TO REMOVE BINDING: binding does not exist for
${urlSuffix}`);
On 2017/03/28 22:51:20, dgozman wrote:
> ditto

Done.

[lushnikov, 2017-03-28 23:17:18]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 23:17:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-03-28 23:22:37]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-03-28 23:22:37]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-03-28 23:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2784733002/#ps20001
(title: "address comments + three special tests")

[commit-bot: I haz the power, 2017-03-28 23:23:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:19:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:19:55]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[lushnikov, 2017-03-29 01:25:56]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:26:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 03:06:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:06:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2017-03-29 04:06:44]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-29 04:07:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 07:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 07:40:23]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2017-03-29 16:40:42]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-29 16:41:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 18:35:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490805642415620,
"parent_rev": "c8cf9f23a6c3b6d69e9528d7e9a4f22f16b7d63e", "commit_rev":
"6b74f6642be4ca9d5af4de7dcc56ea58c3f62e53"}

[commit-bot: I haz the power, 2017-03-29 18:36:32]

Description was changed from

==========
DevTools: prepare tests for Persistence2.0 release

We have a bunch of tests which rely on DefaultMapping to test
Persistence layer. However, they don't test the DefaultMapping
behavior - instead, they want to test the Persistence layer and everyone
who depends on it.

This patch:
- adds a simple TestMapping which controllably adds and removes persistence
  bindings
- moves majority of the tests over to TestMapping
- removes a few tests which were testing themselves

This is a pre-step to enable Persistence2.0.

BUG=277885
R=dgozman
==========

to

==========
DevTools: prepare tests for Persistence2.0 release

We have a bunch of tests which rely on DefaultMapping to test
Persistence layer. However, they don't test the DefaultMapping
behavior - instead, they want to test the Persistence layer and everyone
who depends on it.

This patch:
- adds a simple TestMapping which controllably adds and removes persistence
  bindings
- moves majority of the tests over to TestMapping
- removes a few tests which were testing themselves

This is a pre-step to enable Persistence2.0.

BUG=277885
R=dgozman

Review-Url: https://codereview.chromium.org/2784733002
Cr-Commit-Position: refs/heads/master@{#460466}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b74f6642be4ca9d5af4de7dcc56...
==========

[commit-bot: I haz the power, 2017-03-29 18:36:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6b74f6642be4ca9d5af4de7dcc56...