third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js - Issue 2784733002: DevTools: prepare tests for Persistence2.0 release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js

Issue 2784733002: DevTools: prepare tests for Persistence2.0 release (Closed)

Patch Set: address comments + three special tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js ('k') | third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js b/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js

index 249ba4cace188ff77f06201298d84428a497c516..a5612b4163a9e53c232667a363ddcec901582224 100644

--- a/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js

@@ -134,6 +134,8 @@ Persistence.DefaultMapping = class {

}

dispose() {

+ for (var binding of this._bindings.valuesArray())

+ this._unbind(binding.network);

Common.EventTarget.removeEventListeners(this._eventListeners);

}

};