Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html

Issue 2784733002: DevTools: prepare tests for Persistence2.0 release (Closed)
Patch Set: address comments + three special tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html b/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html
index 6be7a48dfa5d1f5aa1d5e2e753ef86d491eb86b4..b6bf85d3f45bc032ccfddbccf593b4e55ab5e945 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints-on-reload.html
@@ -14,8 +14,8 @@ function addFooJS() {
function test()
{
+ var testMapping = InspectorTest.initializeTestMapping();
var fs = new InspectorTest.TestFileSystem('file:///var/www');
- fs.addFileMapping('http://127.0.0.1:8000', '/');
InspectorTest.addFooJSFile(fs);
InspectorTest.runTestSuite([
@@ -27,6 +27,7 @@ function test()
function addNetworkFooJS(next)
{
InspectorTest.evaluateInPage('addFooJS()');
+ testMapping.addBinding('foo.js');
InspectorTest.waitForBinding('foo.js').then(next);
},
@@ -43,12 +44,16 @@ function test()
}
},
- function reloadPageAndDumpBreakpoints(next)
+ async function reloadPageAndDumpBreakpoints(next)
{
- Promise.all([
+ testMapping.removeBinding('foo.js');
+ await Promise.all([
InspectorTest.waitBreakpointSidebarPane(),
InspectorTest.reloadPagePromise()
- ]).then(dumpBreakpointSidebarPane).then(next);
+ ]);
+ testMapping.addBinding('foo.js');
+ dumpBreakpointSidebarPane();
+ next();
},
]);

Powered by Google App Engine
This is Rietveld 408576698