Turn on auto-dismissing dialogs for trunk builds.

Turn on auto-dismissing dialogs for trunk builds.

BUG=629964
Review-Url: https://codereview.chromium.org/2784533002
Cr-Commit-Position: refs/heads/master@{#468636}
Committed: https://chromium.googlesource.com/chromium/src/+/31f873664134b070fdc2cd2e387edc045de432a8

[Avi (use Gerrit), 2017-03-28 16:27:07]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 16:27:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-28 16:28:00]

avi@chromium.org changed reviewers:
+ nasko@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:09:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nasko, 2017-03-28 17:29:19]

https://codereview.chromium.org/2784533002/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2784533002/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:31: #endif
It isn't very obvious, but the right way to enable it is to change
testing/variations/fieldtrial_testing_config.json and add your field trial as
enabled. This will turn it on for all chromium builds, including trunk and
waterfall. Once you are comfortable you no longer need field trial code, you
just rip it all out.

[nasko, 2017-03-28 17:42:36]

Example of how it was done for Isolate Extensions:
https://codereview.chromium.org/2692153002/

[Avi (use Gerrit), 2017-03-28 19:58:04]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 19:58:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-03-28 19:58:51]

https://codereview.chromium.org/2784533002/diff/1/chrome/browser/ui/javascrip...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
(right):

https://codereview.chromium.org/2784533002/diff/1/chrome/browser/ui/javascrip...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:31: #endif
On 2017/03/28 17:29:19, nasko wrote:
> It isn't very obvious, but the right way to enable it is to change
> testing/variations/fieldtrial_testing_config.json and add your field trial as
> enabled. This will turn it on for all chromium builds, including trunk and
> waterfall. Once you are comfortable you no longer need field trial code, you
> just rip it all out.

The more you know...

(how do you know this?)

[nasko, 2017-03-28 20:06:30]

On 2017/03/28 19:58:51, Avi wrote:
>
https://codereview.chromium.org/2784533002/diff/1/chrome/browser/ui/javascrip...
> File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
> (right):
> 
>
https://codereview.chromium.org/2784533002/diff/1/chrome/browser/ui/javascrip...
> chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc:31:
#endif
> On 2017/03/28 17:29:19, nasko wrote:
> > It isn't very obvious, but the right way to enable it is to change
> > testing/variations/fieldtrial_testing_config.json and add your field trial
as
> > enabled. This will turn it on for all chromium builds, including trunk and
> > waterfall. Once you are comfortable you no longer need field trial code, you
> > just rip it all out.
> 
> The more you know...
> 
> (how do you know this?)

The README.md in the directory. Easily readable as
https://chromium.googlesource.com/chromium/src.git/+/master/testing/variations/.

[commit-bot: I haz the power, 2017-03-28 20:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 20:30:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-03-28 20:35:27]

ptal.

[Avi (use Gerrit), 2017-03-28 20:35:28]

ptal.

[Avi (use Gerrit), 2017-03-28 20:40:47]

On 2017/03/28 20:35:28, Avi wrote:
> ptal.

Oooooooooh. I think I need to get the tests working. Yikes.

[nasko, 2017-03-29 00:06:28]

The change itself looks fine, but it doesn't make the bots happy :).

[Avi (use Gerrit), 2017-03-29 03:14:39]

On 2017/03/29 00:06:28, nasko wrote:
> The change itself looks fine, but it doesn't make the bots happy :).

Yeah. I will be auditing the tests to see why they don't interact well with the
dialogs.

I'll ping you when this is ready for a look. Sorry for asking for review before
getting green.

[Avi (use Gerrit), 2017-04-26 19:06:19]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 19:07:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 19:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 19:51:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2017-04-28 23:47:28]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:48:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 00:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 00:24:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-04-29 21:37:51]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 21:38:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-04-29 22:30:03]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 22:30:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 23:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 23:03:05]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Avi (use Gerrit), 2017-04-30 03:31:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-30 03:31:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-04-30 03:58:01]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-30 03:58:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 04:59:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-30 04:59:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-05-01 00:31:47]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 00:31:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 01:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 01:44:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-05-01 15:46:08]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 15:46:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 16:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 16:55:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2017-05-01 17:03:12]

avi@chromium.org changed reviewers:
+ isherman@chromium.org, jochen@chromium.org, rdevlin.cronin@chromium.org
- nasko@chromium.org

[Avi (use Gerrit), 2017-05-01 17:03:12]

Ilya: testing/variations
Devlin: chrome/browser/extensions
Jochen: everything else

[Devlin, 2017-05-01 17:12:22]

extensions lgtm.  So much cleaner! :)

https://codereview.chromium.org/2784533002/diff/140001/chrome/browser/ui/java...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
(right):

https://codereview.chromium.org/2784533002/diff/140001/chrome/browser/ui/java...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h:40: bool
IsShowingDialogForTesting();
drive-by nit: bool IsShowingDialogForTesting() const;

[Avi (use Gerrit), 2017-05-01 17:42:24]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 17:43:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-05-01 17:58:38]

fieldtrial changes lgtm

[Avi (use Gerrit), 2017-05-01 18:19:09]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 18:19:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-05-01 18:55:22]

avi@chromium.org changed reviewers:
+ alemate@chromium.org

[Avi (use Gerrit), 2017-05-01 18:55:23]

Alexander: ChromeOS file, please (missed it earlier)

https://codereview.chromium.org/2784533002/diff/140001/chrome/browser/ui/java...
File chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
(right):

https://codereview.chromium.org/2784533002/diff/140001/chrome/browser/ui/java...
chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h:40: bool
IsShowingDialogForTesting();
On 2017/05/01 17:12:22, Devlin wrote:
> drive-by nit: bool IsShowingDialogForTesting() const;

Done.

[commit-bot: I haz the power, 2017-05-01 19:09:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 19:09:50]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2017-05-01 20:47:16]

chrome/browser/chromeos/login/signin/ lgtm

[jochen (gone - plz use gerrit), 2017-05-02 09:13:06]

lgtm

[Avi (use Gerrit), 2017-05-02 15:05:05]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2017-05-02 15:05:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2784533002/#ps180001
(title: "chromeos")

[commit-bot: I haz the power, 2017-05-02 15:05:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 15:09:36]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1493737505310060,
"parent_rev": "82ca516cd377e8956d47f29cb43215c0bd622f3d", "commit_rev":
"31f873664134b070fdc2cd2e387edc045de432a8"}

[commit-bot: I haz the power, 2017-05-02 15:09:50]

Description was changed from

==========
Turn on auto-dismissing dialogs for trunk builds.

BUG=629964
==========

to

==========
Turn on auto-dismissing dialogs for trunk builds.

BUG=629964

Review-Url: https://codereview.chromium.org/2784533002
Cr-Commit-Position: refs/heads/master@{#468636}
Committed:
https://chromium.googlesource.com/chromium/src/+/31f873664134b070fdc2cd2e387e...
==========

[commit-bot: I haz the power, 2017-05-02 15:09:53]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/31f873664134b070fdc2cd2e387e...