Turn on auto-dismissing dialogs for trunk builds.

chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/feature_list.h"
 #include "base/metrics/histogram_macros.h"
 #include "chrome/browser/engagement/site_engagement_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tab_modal_confirm_dialog.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_features.h"
 #include "components/app_modal/javascript_dialog_manager.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/render_frame_host.h"
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(JavaScriptDialogTabHelper);
 
 namespace {
 
 bool IsEnabled() {
+#if defined(GOOGLE_CHROME_BUILD)
   return base::FeatureList::IsEnabled(features::kAutoDismissingDialogs);
+#else
+  return true;
+#endif

[nasko, 2017/03/28 17:29:19]

It isn't very obvious, but the right way to enable it is to change
testing/variations/fieldtrial_testing_config.json and add your field trial as
enabled. This will turn it on for all chromium builds, including trunk and
waterfall. Once you are comfortable you no longer need field trial code, you
just rip it all out.

[Avi (use Gerrit), 2017/03/28 19:58:51]

The more you know...

(how do you know this?)

 }
 
 app_modal::JavaScriptDialogManager* AppModalDialogManager() {
   return app_modal::JavaScriptDialogManager::GetInstance();
 }
 
 bool IsWebContentsForemost(content::WebContents* web_contents) {
   Browser* browser = BrowserList::GetInstance()->GetLastActive();
   DCHECK(browser);
   return browser->tab_strip_model()->GetActiveWebContents() == web_contents;
@@ skipping 290 matching lines @@
   dialog_callback_.Run(success, user_input);
 
   ClearDialogInfo();
 }
 
 void JavaScriptDialogTabHelper::ClearDialogInfo() {
   dialog_.reset();
   dialog_callback_.Reset();
   BrowserList::RemoveObserver(this);
 }