chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc - Issue 2784533002: Turn on auto-dismissing dialogs for trunk builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

Issue 2784533002: Turn on auto-dismissing dialogs for trunk builds. (Closed)

Patch Set: chromeos Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h ('k') | testing/variations/fieldtrial_testing_config.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

index 76ac346a9786cbd6c6369d1357373f1ed4366985..789b222756c01adcaaf490453abfb38d7dbeac8d 100644

--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc

@@ -88,6 +88,10 @@ void JavaScriptDialogTabHelper::SetDialogShownCallbackForTesting(

dialog_shown_ = callback;

}

+bool JavaScriptDialogTabHelper::IsShowingDialogForTesting() const {

+ return !!dialog_;

void JavaScriptDialogTabHelper::RunJavaScriptDialog(

content::WebContents* alerting_web_contents,

const GURL& origin_url,