Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2784403002: Store gin::IsolateHolder as a plain member of V8PerIsolateData. (Closed)

Created:
3 years, 8 months ago by jbroman
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Store gin::IsolateHolder as a plain member of V8PerIsolateData. No apparent reason for this to be separately allocated (the defining header is even included already). This removes a pointer indirection in V8PerIsolateData::isolate, which happens fairly frequently. Review-Url: https://codereview.chromium.org/2784403002 Cr-Commit-Position: refs/heads/master@{#460953} Committed: https://chromium.googlesource.com/chromium/src/+/626ba1ac1e8f5cd247fd1ae17fe87629dbb0ec0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jbroman
This seems slightly simpler, but it probably doesn't matter much. WDYT?
3 years, 8 months ago (2017-03-30 22:26:57 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-03-31 00:01:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784403002/1
3 years, 8 months ago (2017-03-31 00:05:01 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 00:37:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/626ba1ac1e8f5cd247fd1ae17fe8...

Powered by Google App Engine
This is Rietveld 408576698