Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2784403002: Store gin::IsolateHolder as a plain member of V8PerIsolateData. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
index 780e2471a9ffa4d4931cce03abe99f228458b145..0b639f9485c3cfb1f751417821cbf0012e0544d8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
@@ -114,7 +114,7 @@ class CORE_EXPORT V8PerIsolateData {
static void enableIdleTasks(v8::Isolate*,
std::unique_ptr<gin::V8IdleTaskRunner>);
- v8::Isolate* isolate() { return m_isolateHolder->isolate(); }
+ v8::Isolate* isolate() { return m_isolateHolder.isolate(); }
StringCache* getStringCache() { return m_stringCache.get(); }
@@ -236,7 +236,7 @@ class CORE_EXPORT V8PerIsolateData {
v8::Local<v8::Value>,
V8FunctionTemplateMap&);
- std::unique_ptr<gin::IsolateHolder> m_isolateHolder;
+ gin::IsolateHolder m_isolateHolder;
// m_interfaceTemplateMapFor{,Non}MainWorld holds function templates for
// the inerface objects.
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698