Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2784403002: Store gin::IsolateHolder as a plain member of V8PerIsolateData. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index bca8f89e360b9637ed13b3d07b2491c3ea07ec99..f28a0b17f478f7d3cd3e8a7469fa6a9a6e832b80 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -54,11 +54,11 @@ static void microtasksCompletedCallback(v8::Isolate* isolate) {
}
V8PerIsolateData::V8PerIsolateData(WebTaskRunner* taskRunner)
- : m_isolateHolder(WTF::makeUnique<gin::IsolateHolder>(
+ : m_isolateHolder(
taskRunner ? taskRunner->toSingleThreadTaskRunner() : nullptr,
gin::IsolateHolder::kSingleThread,
isMainThread() ? gin::IsolateHolder::kDisallowAtomicsWait
- : gin::IsolateHolder::kAllowAtomicsWait)),
+ : gin::IsolateHolder::kAllowAtomicsWait),
m_stringCache(WTF::wrapUnique(new StringCache(isolate()))),
m_hiddenValue(V8HiddenValue::create()),
m_privateProperty(V8PrivateProperty::create()),
@@ -91,8 +91,7 @@ v8::Isolate* V8PerIsolateData::initialize(WebTaskRunner* taskRunner) {
void V8PerIsolateData::enableIdleTasks(
v8::Isolate* isolate,
std::unique_ptr<gin::V8IdleTaskRunner> taskRunner) {
- from(isolate)->m_isolateHolder->EnableIdleTasks(
- std::unique_ptr<gin::V8IdleTaskRunner>(taskRunner.release()));
+ from(isolate)->m_isolateHolder.EnableIdleTasks(std::move(taskRunner));
}
v8::Persistent<v8::Value>& V8PerIsolateData::ensureLiveRoot() {
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698