Android: Remove GetApplicationContext part 2

Android: Remove GetApplicationContext part 2

Part 1: https://codereview.chromium.org/2772343003/

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094
Review-Url: https://codereview.chromium.org/2784353002
Cr-Commit-Position: refs/heads/master@{#462438}
Committed: https://chromium.googlesource.com/chromium/src/+/e561a3b69799a67eef58831f83949d987b6a92fd

[Peter Wen, 2017-03-30 16:26:57]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 16:27:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 17:46:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 17:46:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Peter Wen, 2017-03-30 18:45:24]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 18:46:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-03-30 21:33:02]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[Peter Wen, 2017-03-30 21:33:03]

Sorry for the large CL 🚗

[agrieve, 2017-03-31 14:34:05]

On 2017/03/30 21:33:03, Peter Wen wrote:
> Sorry for the large CL 🚗

Wow, my brain hurts a little now, but I couldn't seen any mixups. Tried to
validate that you were only ever inlining application context (as opposed to
other Context types), but it looks to me like that's the case. lgtm.

[agrieve, 2017-03-31 14:34:28]

/w nit

https://codereview.chromium.org/2784353002/diff/60001/base/test/android/java/...
File
base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java
(right):

https://codereview.chromium.org/2784353002/diff/60001/base/test/android/java/...
base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java:47:
private static int launchClient(
Not sure if this was caused by you or a cl in between, but there's a huge diff
on this one because the methods have moved. Could you try and fix this up?

[agrieve, 2017-03-31 14:38:14]

brettw for root owner (large mechanical change).

[Peter Wen, 2017-04-04 19:08:35]

wnwen@chromium.org changed reviewers:
+ brettw@chromium.org

[Peter Wen, 2017-04-04 19:08:36]

Thanks for the review, Andrew! Appreciate it.

+brettw@ for global OWNERS as this is a mostly mechanical large-scale
refactoring.

Part 1 for reference here: http://crrev.com/2772343003

https://codereview.chromium.org/2784353002/diff/60001/base/test/android/java/...
File
base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java
(right):

https://codereview.chromium.org/2784353002/diff/60001/base/test/android/java/...
base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java:47:
private static int launchClient(
On 2017/03/31 14:34:28, agrieve wrote:
> Not sure if this was caused by you or a cl in between, but there's a huge diff
> on this one because the methods have moved. Could you try and fix this up?

Done.

[Peter Wen, 2017-04-04 20:29:24]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 20:30:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2017-04-04 21:17:16]

rs lgtm

[commit-bot: I haz the power, 2017-04-04 22:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 22:17:58]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Peter Wen, 2017-04-05 18:01:06]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:02:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:07:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Peter Wen, 2017-04-05 18:14:18]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:14:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 18:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 18:36:42]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Peter Wen, 2017-04-05 18:53:01]

The CQ bit was checked by wnwen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:53:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-04-05 19:26:23]

The CQ bit was unchecked by wnwen@chromium.org

[Peter Wen, 2017-04-05 19:26:32]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-04-05 19:26:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2784353002/#ps140001
(title: "Fix rebase")

[commit-bot: I haz the power, 2017-04-05 19:27:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Wen, 2017-04-05 20:46:19]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-04-05 20:46:20]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2784353002/#ps160001
(title: "Fix tests")

[commit-bot: I haz the power, 2017-04-05 20:47:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 21:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:18:51]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Peter Wen, 2017-04-06 12:10:00]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2017-04-06 12:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 12:35:04]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1491480600350160,
"parent_rev": "ac773da2b6b772f2c4d50b4655be924143f5643a", "commit_rev":
"e561a3b69799a67eef58831f83949d987b6a92fd"}

[commit-bot: I haz the power, 2017-04-06 12:35:56]

Description was changed from

==========
Android: Remove GetApplicationContext part 2

Part 1: https://codereview.chromium.org/2772343003/

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094
==========

to

==========
Android: Remove GetApplicationContext part 2

Part 1: https://codereview.chromium.org/2772343003/

Java-side already has the ContextUtils#GetApplicationContext global and
no longer needs native to hold the pointer and pass it through jni with
every call that needs an application context.

BUG=646094

Review-Url: https://codereview.chromium.org/2784353002
Cr-Commit-Position: refs/heads/master@{#462438}
Committed:
https://chromium.googlesource.com/chromium/src/+/e561a3b69799a67eef58831f8394...
==========

[commit-bot: I haz the power, 2017-04-06 12:35:58]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/e561a3b69799a67eef58831f8394...

[Peter Wen, 2017-04-06 12:53:45]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2800833003/ by wnwen@chromium.org.

The reason for reverting is: Missing change to ClearBrowsingDataPreferencesBasic

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid....

[findit-for-me, 2017-04-06 12:54:16]

Findit confirmed this CL at revision 462438 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[jkrcal, 2017-04-06 12:56:22]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2801033002/ by jkrcal@chromium.org.

The reason for reverting is: The CL has broken the tree

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Buil....

[jkrcal, 2017-04-06 13:03:09]

On 2017/04/06 12:56:22, jkrcal wrote:
> A revert of this CL (patchset #9 id:160001) has been created in
> https://codereview.chromium.org/2801033002/ by mailto:jkrcal@chromium.org.
> 
> The reason for reverting is: The CL has broken the tree
> 
>
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Buil....

Peter, thanks for reverting and re-opening the tree!