Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java

Issue 2784353002: Android: Remove GetApplicationContext part 2 (Closed)
Patch Set: Fix tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java
index a1b8b11dc0eaf03d1298eb8d5fd0d2b373c25470..8500c46bc7e0d3a9d7baa0f3eab0f83c4628c914 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java
@@ -75,7 +75,7 @@ public class OAuth2TokenServiceIntegrationTest {
AccountManagerHelper.overrideAccountManagerHelperForTests(mContext, mAccountManager);
// Make sure there is no account signed in yet.
- mChromeSigninController = ChromeSigninController.get(mContext);
+ mChromeSigninController = ChromeSigninController.get();
mChromeSigninController.setSignedInAccountName(null);
// Seed test accounts to AccountTrackerService.
@@ -95,7 +95,7 @@ public class OAuth2TokenServiceIntegrationTest {
@Override
public void run() {
mChromeSigninController.setSignedInAccountName(null);
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
}
});
}
@@ -106,12 +106,12 @@ public class OAuth2TokenServiceIntegrationTest {
public void run() {
AccountIdProvider.setInstanceForTest(new AccountIdProvider() {
@Override
- public String getAccountId(Context ctx, String accountName) {
+ public String getAccountId(String accountName) {
return "gaia-id-" + accountName;
}
@Override
- public boolean canBeUsed(Context ctx) {
+ public boolean canBeUsed() {
return true;
}
});
@@ -125,10 +125,9 @@ public class OAuth2TokenServiceIntegrationTest {
public void run() {
AccountIdProvider provider = AccountIdProvider.getInstance();
String[] accountNames = {TEST_ACCOUNT1.name, TEST_ACCOUNT2.name};
- String[] accountIds = {provider.getAccountId(context, accountNames[0]),
- provider.getAccountId(context, accountNames[1])};
- AccountTrackerService.get(context).syncForceRefreshForTest(
- accountIds, accountNames);
+ String[] accountIds = {provider.getAccountId(accountNames[0]),
+ provider.getAccountId(accountNames[1])};
+ AccountTrackerService.get().syncForceRefreshForTest(accountIds, accountNames);
}
});
}
@@ -244,7 +243,7 @@ public class OAuth2TokenServiceIntegrationTest {
@Override
public void run() {
// Run test.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
// Ensure no calls have been made to the observer.
Assert.assertEquals(0, mObserver.getAvailableCallCount());
@@ -264,7 +263,7 @@ public class OAuth2TokenServiceIntegrationTest {
mAccountManager.addAccountHolderExplicitly(TEST_ACCOUNT_HOLDER_1);
// Run test.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
// Ensure no calls have been made to the observer.
Assert.assertEquals(0, mObserver.getAvailableCallCount());
@@ -287,7 +286,7 @@ public class OAuth2TokenServiceIntegrationTest {
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
// Run test.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
// Ensure one call for the signed in account.
Assert.assertEquals(1, mObserver.getAvailableCallCount());
@@ -295,13 +294,13 @@ public class OAuth2TokenServiceIntegrationTest {
Assert.assertEquals(0, mObserver.getLoadedCallCount());
// Validate again and make sure no new calls are made.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(1, mObserver.getAvailableCallCount());
Assert.assertEquals(0, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
// Validate again with force notifications and make sure one new calls is made.
- mOAuth2TokenService.validateAccounts(mContext, true);
+ mOAuth2TokenService.validateAccounts(true);
Assert.assertEquals(2, mObserver.getAvailableCallCount());
Assert.assertEquals(0, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
@@ -322,13 +321,13 @@ public class OAuth2TokenServiceIntegrationTest {
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
// Run one validation.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(1, mObserver.getAvailableCallCount());
Assert.assertEquals(0, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
// Re-run validation.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(1, mObserver.getAvailableCallCount());
Assert.assertEquals(0, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
@@ -349,7 +348,7 @@ public class OAuth2TokenServiceIntegrationTest {
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
// Run one validation.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(1, mObserver.getAvailableCallCount());
Assert.assertEquals(0, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
@@ -361,7 +360,7 @@ public class OAuth2TokenServiceIntegrationTest {
seedAccountTrackerService(mContext);
// Re-run validation.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(2, mObserver.getAvailableCallCount());
Assert.assertEquals(0, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
@@ -383,11 +382,11 @@ public class OAuth2TokenServiceIntegrationTest {
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
// Run one validation.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(2, mObserver.getAvailableCallCount());
mAccountManager.removeAccountHolderExplicitly(TEST_ACCOUNT_HOLDER_2);
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(2, mObserver.getAvailableCallCount());
Assert.assertEquals(1, mObserver.getRevokedCallCount());
@@ -409,7 +408,7 @@ public class OAuth2TokenServiceIntegrationTest {
// Mark user as signed in.
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(2, mObserver.getAvailableCallCount());
// Remove all.
@@ -417,7 +416,7 @@ public class OAuth2TokenServiceIntegrationTest {
mAccountManager.removeAccountHolderExplicitly(TEST_ACCOUNT_HOLDER_2);
// Re-validate and run checks.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(2, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
}
@@ -438,7 +437,7 @@ public class OAuth2TokenServiceIntegrationTest {
// Mark user as signed in.
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(2, mObserver.getAvailableCallCount());
// Remove all.
@@ -447,7 +446,7 @@ public class OAuth2TokenServiceIntegrationTest {
mAccountManager.removeAccountHolderExplicitly(TEST_ACCOUNT_HOLDER_2);
// Re-validate and run checks.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
Assert.assertEquals(2, mObserver.getRevokedCallCount());
Assert.assertEquals(0, mObserver.getLoadedCallCount());
}
@@ -468,7 +467,7 @@ public class OAuth2TokenServiceIntegrationTest {
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
// Run test.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
// All accounts will be notified. It is up to the observer
// to design if any action is needed.
@@ -489,7 +488,7 @@ public class OAuth2TokenServiceIntegrationTest {
mChromeSigninController.setSignedInAccountName(TEST_ACCOUNT1.name);
// Run test.
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
// Ensure no calls have been made to the observer.
Assert.assertEquals(0, mObserver.getAvailableCallCount());
@@ -511,12 +510,12 @@ public class OAuth2TokenServiceIntegrationTest {
@Override
public void onRefreshTokenAvailable(Account account) {
super.onRefreshTokenAvailable(account);
- Assert.assertEquals(1, OAuth2TokenService.getAccounts(mContext).length);
+ Assert.assertEquals(1, OAuth2TokenService.getAccounts().length);
}
};
addObserver(ob);
- mOAuth2TokenService.validateAccounts(mContext, false);
+ mOAuth2TokenService.validateAccounts(false);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698