Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2783553002: Convert AudioBufferSource tests to new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert AudioBufferSource tests to new Audit Manually converted tests to use new Audit. BUG=704967 TEST= AudioBufferSource/audiobuffersource-detune-modulated-impulse.html AudioBufferSource/audiobuffersource-detune-modulation.html AudioBufferSource/audiobuffersource-late-start.html AudioBufferSource/audiobuffersource-loop-grain-no-duration.html AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse.html AudioBufferSource/audiobuffersource-playbackrate-modulation.html AudioBufferSource/audiobuffersource-playbackrate-zero.html AudioBufferSource/audiobuffersource-playbackrate.html AudioBufferSource/audiobuffersource-premature-loop-stop.html AudioBufferSource/audiobuffersource.html AudioBufferSource/audiosource-onended.html AudioBufferSource/audiosource-premature-gc.html AudioBufferSource/audiosource-time-limits.html resources/audit-util.js Review-Url: https://codereview.chromium.org/2783553002 Cr-Commit-Position: refs/heads/master@{#462262} Committed: https://chromium.googlesource.com/chromium/src/+/c54f19fb954b6b55ea85f4c594e048ca0dd5b207

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Clean up some messages; replace call to testFailed. #

Patch Set 4 : Indent neatly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -209 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse.html View 1 2 3 3 chunks +26 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-detune-modulation.html View 5 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-late-start.html View 3 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration.html View 1 2 3 4 chunks +13 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate.html View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse.html View 3 chunks +26 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html View 1 2 5 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero.html View 3 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html View 3 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-onended.html View 1 2 3 3 chunks +26 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-premature-gc.html View 1 2 3 4 chunks +11 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-time-limits.html View 1 2 3 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js View 1 2 3 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-05 17:01:16 UTC) #2
hongchan
lgtm
3 years, 8 months ago (2017-04-05 21:35:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783553002/60001
3 years, 8 months ago (2017-04-05 21:49:32 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 23:17:10 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c54f19fb954b6b55ea85f4c594e0...

Powered by Google App Engine
This is Rietveld 408576698