third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html - Issue 2783553002: Convert AudioBufferSource tests to new Audit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html

Issue 2783553002: Convert AudioBufferSource tests to new Audit (Closed)

Patch Set: Indent neatly. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-zero.html ('k') | third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiosource-onended.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html b/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html

index 6b6179444835fd51a0738b5b58f553d055f10be0..598a9b48149fd726a93083ce5c567be70840e8bb 100644

--- a/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html

+++ b/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html

@@ -6,7 +6,7 @@

- <script src="../resources/audio-testing.js"></script>

+ <script src="../resources/audit.js"></script>

</head>

<body>

@@ -21,7 +21,7 @@

// 3]. Then set a loop range over the second region. Start the loop and

// disable it in the middle of looping. Verify the rendered buffer has the

// entire content including the looped region.

- audit.defineTask('premature-loop-stop', function (done) {

+ audit.define('premature-loop-stop', (task, should) => {

var regionValues = [1, 2, 3];

// The region length is 2 * render quantum size to be able to suspend the

@@ -70,19 +70,13 @@

var region2 = channel.subarray(regionLength, 4 * regionLength - 1);

var region3 = channel.subarray(4 * regionLength, 5 * regionLength - 1);

- Should('Region #1', region1).beConstantValueOf(1);

- Should('Region #2 (looped)', region2).beConstantValueOf(2);

- Should('Region #3', region3).beConstantValueOf(3);

- }).then(done);

+ should(region1, 'Region #1').beConstantValueOf(1);

+ should(region2, 'Region #2 (looped)').beConstantValueOf(2);

+ should(region3, 'Region #3').beConstantValueOf(3);

+ }).then(() => task.done());

});

- audit.defineTask('finish', function (done) {

- done();

- });

- audit.runTasks();

- successfullyParsed = true;

+ audit.run();

</script>

</body>