Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html

Issue 2783553002: Convert AudioBufferSource tests to new Audit (Closed)
Patch Set: Indent neatly. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html b/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html
index 446bd4364f1f4413de33d782a7c7fa53e2265da2..4fd472751a04b93d3cf86c125fd42553171ffd93 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html
@@ -5,7 +5,7 @@
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
- <script src="../resources/audio-testing.js"></script>
+ <script src="../resources/audit.js"></script>
<script src="../resources/audiobuffersource-testing.js"></script>
<script src="../resources/buffer-loader.js"></script>
</head>
@@ -23,12 +23,13 @@
// Task: Load the reference file asynchronously. In order to create a new
// reference file, use the task 'generate-reference' below.
- audit.defineTask('load-reference', function (done) {
+ audit.define('load-reference', (task, should) => {
var loader = new BufferLoader(context, [
'audiobuffersource-playbackrate-modulation-expected.wav'
], function (bufferList) {
referenceBuffer = bufferList[0];
- done();
+ should(true, "Loaded reference file").beTrue();
+ task.done();
});
loader.load();
@@ -36,7 +37,7 @@
// Task: Render the actual buffer and compare with the reference.
- audit.defineTask('generate-verify', function (done) {
+ audit.define('generate-verify', (task, should) => {
// With this setting, the playback rate will be changing continuously and
// repeatedly within the range of [0, 200] around 100Hz, based on the
@@ -49,7 +50,8 @@
// Compare two buffers with arbitrary (yet reasonable) constraints.
// There parameters are determined by try bot experiments.
- compareBuffersWithConstraints(actual, expected, {
+ compareBuffersWithConstraints(should, actual, expected, {
+ prefix: "Verify",
thresholdSNR: 92.72,
thresholdDiffULP: 0.985,
thresholdDiffCount: 0,
@@ -58,11 +60,11 @@
var filename = 'audiobuffersource-playbackrate-modulation-actual.wav';
if (downloadAudioBuffer(renderedBuffer, filename))
- Should("Saved reference file", true).summarize(filename, "");
- }).then(done);
+ should(true, "Saved reference file").message(filename, "");
+ }).then(() => task.done());
});
- audit.runTasks();
+ audit.run();
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698