Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2783233005: DevTools: Move JavaScript and CSS outline into QuickOpen (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move JavaScript and CSS outline into QuickOpen This combines JavaScriptOutlineDialog and StyleSheetOutlineDialog into a single QuickOpen provider. BUG=662081 Review-Url: https://codereview.chromium.org/2783233005 Cr-Commit-Position: refs/heads/master@{#461988} Committed: https://chromium.googlesource.com/chromium/src/+/b4ad68a17ae6822adc2c4ed33b43712686198161

Patch Set 1 #

Messages

Total messages: 12 (6 generated)
einbinder
ptal
3 years, 8 months ago (2017-03-31 23:46:06 UTC) #2
pfeldman
lgtm rock'n'roll!
3 years, 8 months ago (2017-04-04 20:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783233005/1
3 years, 8 months ago (2017-04-04 22:13:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/264679)
3 years, 8 months ago (2017-04-05 01:46:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783233005/1
3 years, 8 months ago (2017-04-05 05:00:32 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 05:49:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4ad68a17ae6822adc2c4ed33b43...

Powered by Google App Engine
This is Rietveld 408576698