Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/javascript-outline-dialog.html

Issue 2783233005: DevTools: Move JavaScript and CSS outline into QuickOpen (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/javascript-outline-dialog.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/javascript-outline-dialog.html b/third_party/WebKit/LayoutTests/inspector/sources/javascript-outline-dialog.html
index 2da437e3b5eb0c842dd80a1658dfc05be4109649..4055214d004da75f8d414b22f31b12ec4ecdbc13 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/javascript-outline-dialog.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/javascript-outline-dialog.html
@@ -10,14 +10,16 @@
function test()
{
InspectorTest.showScriptSource("javascript-outline-dialog.js", onSourceShown);
+ var provider;
function onSourceShown(sourceFrame)
{
- InspectorTest.addSniffer(Sources.JavaScriptOutlineDialog.prototype, "refresh", onDialogFulfilled);
- UI.panels.sources._sourcesView._showOutlineDialog();
+ InspectorTest.addSniffer(Sources.OutlineQuickOpen.prototype, "refresh", onQuickOpenFulfilled);
+ UI.panels.sources._sourcesView._showOutlineQuickOpen();
}
- function onDialogFulfilled()
+ function onQuickOpenFulfilled()
{
+ provider = this;
dumpScores("te");
dumpScores("test");
dumpScores("test(");
@@ -28,12 +30,11 @@ function test()
function dumpScores(query)
{
InspectorTest.addResult(`Scores for query="${query}"`);
- var dialog = Sources.JavaScriptOutlineDialog._instanceForTests;
var keys = [];
- for (var i = 0; i < dialog.itemCount(); ++i) {
+ for (var i = 0; i < provider.itemCount(); ++i) {
keys.push({
- key: dialog.itemKeyAt(i),
- score: dialog.itemScoreAt(i, query)
+ key: provider.itemKeyAt(i),
+ score: provider.itemScoreAt(i, query)
});
}
keys.sort((a,b) => b.score - a.score);
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/css-outline-dialog.html ('k') | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698