Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Issue 2783233005: DevTools: Move JavaScript and CSS outline into QuickOpen (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
index 0655704420679172fc91dc5f5a7ce5f1bb66cf08..1736ddc220bfff57deb3b6a4b1320226d6b179fc 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
@@ -133,7 +133,7 @@ Sources.SourcesView = class extends UI.VBox {
registerShortcut.call(
this, UI.ShortcutsScreen.SourcesPanelShortcuts.GoToLine, this._showGoToLineQuickOpen.bind(this));
registerShortcut.call(
- this, UI.ShortcutsScreen.SourcesPanelShortcuts.GoToMember, this._showOutlineDialog.bind(this));
+ this, UI.ShortcutsScreen.SourcesPanelShortcuts.GoToMember, this._showOutlineQuickOpen.bind(this));
registerShortcut.call(
this, UI.ShortcutsScreen.SourcesPanelShortcuts.ToggleBreakpoint, this._toggleBreakpoint.bind(this));
registerShortcut.call(this, UI.ShortcutsScreen.SourcesPanelShortcuts.Save, this._save.bind(this));
@@ -598,24 +598,9 @@ Sources.SourcesView = class extends UI.VBox {
/**
* @param {!Event=} event
- * @return {boolean}
*/
- _showOutlineDialog(event) {
- var uiSourceCode = this._editorContainer.currentFile();
- if (!uiSourceCode)
- return false;
-
- if (uiSourceCode.contentType().hasScripts()) {
- Sources.JavaScriptOutlineDialog.show(uiSourceCode, this.showSourceLocation.bind(this, uiSourceCode));
- return true;
- }
-
- if (uiSourceCode.contentType().isStyleSheet()) {
- Sources.StyleSheetOutlineDialog.show(uiSourceCode, this.showSourceLocation.bind(this, uiSourceCode));
- return true;
- }
-
- // We don't want default browser shortcut to be executed, so pretend to handle this event.
+ _showOutlineQuickOpen(event) {
+ QuickOpen.QuickOpen.show('@');
return true;
}

Powered by Google App Engine
This is Rietveld 408576698