Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2783193002: Reland of "Update linux sysroot from Wheezy to Jessie" (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, grt+watch_chromium.org, piman+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org, kalyank, Michael Moss, Tom Anderson, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2780763002/ ) Reason for revert: V8 bots are upgraded. Original issue's description: > Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #2 id:240001 of https://codereview.chromium.org/2776773002/ ) > > Reason for revert: > Breaks V8 perf testing: > http://crbug.com/705870 > > Original issue's description: > > Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772113002/ ) > > > > Reason for revert: > > Relanding with fixed deps > > > > Original issue's description: > > > Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ ) > > > > > > Reason for revert: > > > expected_deps_x64_jessie changes are causing a failure on the official builder > > > > > > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout > > > > > > Original issue's description: > > > > Reland of "Update linux sysroot from Wheezy to Jessie" > > > > > > > > The last version of this change was: > > > > https://codereview.chromium.org/2748183005 > > > > > > > > Which was reverted in: > > > > https://codereview.chromium.org/2776503002 > > > > > > > > I've updated the expected package deps again, this > > > > time being sure to use is_chrome_branded=true when > > > > testing (which oddly seems to effect the deps). > > > > > > > > TBR=thestig (since this is effectively a reland) > > > > BUG=701894 > > > > > > > > Review-Url: https://codereview.chromium.org/2772503005 > > > > Cr-Commit-Position: refs/heads/master@{#459492} > > > > Committed: https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47 > > > > > > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=701894 > > > > > > Review-Url: https://codereview.chromium.org/2772113002 > > > Cr-Commit-Position: refs/heads/master@{#459553} > > > Committed: https://chromium.googlesource.com/chromium/src/+/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd > > > > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=701894 > > > > Review-Url: https://codereview.chromium.org/2776773002 > > Cr-Commit-Position: refs/heads/master@{#459584} > > Committed: https://chromium.googlesource.com/chromium/src/+/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed > > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=701894 > > Review-Url: https://codereview.chromium.org/2780763002 > Cr-Commit-Position: refs/heads/master@{#460070} > Committed: https://chromium.googlesource.com/chromium/src/+/75a1434be05f2ef09c307f7b70713385232a5b84 TBR=dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=701894 Review-Url: https://codereview.chromium.org/2783193002 Cr-Commit-Position: refs/heads/master@{#460795} Committed: https://chromium.googlesource.com/chromium/src/+/2183884b24334db9eb57f544388c963dd2694f8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -71 lines) Patch
M build/config/sysroot.gni View 2 chunks +6 lines, -12 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 4 chunks +25 lines, -33 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32_jessie View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 2 chunks +4 lines, -1 line 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/copyright_scanner/copyright_scanner.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
Created Reland of "Update linux sysroot from Wheezy to Jessie"
3 years, 8 months ago (2017-03-30 12:27:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783193002/1
3 years, 8 months ago (2017-03-30 12:27:25 UTC) #3
Sam Clegg
lgtm
3 years, 8 months ago (2017-03-30 16:27:10 UTC) #4
Sam Clegg
lgtm
3 years, 8 months ago (2017-03-30 16:27:12 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 16:51:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2183884b24334db9eb57f544388c...

Powered by Google App Engine
This is Rietveld 408576698