Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2780763002: Revert of "Update linux sysroot from Wheezy to Jessie" (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, grt+watch_chromium.org, piman+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org, kalyank, Michael Moss, Tom Anderson, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #2 id:240001 of https://codereview.chromium.org/2776773002/ ) Reason for revert: Breaks V8 perf testing: http://crbug.com/705870 Original issue's description: > Reland of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772113002/ ) > > Reason for revert: > Relanding with fixed deps > > Original issue's description: > > Revert of "Update linux sysroot from Wheezy to Jessie" (patchset #1 id:1 of https://codereview.chromium.org/2772503005/ ) > > > > Reason for revert: > > expected_deps_x64_jessie changes are causing a failure on the official builder > > > > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F16997%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout > > > > Original issue's description: > > > Reland of "Update linux sysroot from Wheezy to Jessie" > > > > > > The last version of this change was: > > > https://codereview.chromium.org/2748183005 > > > > > > Which was reverted in: > > > https://codereview.chromium.org/2776503002 > > > > > > I've updated the expected package deps again, this > > > time being sure to use is_chrome_branded=true when > > > testing (which oddly seems to effect the deps). > > > > > > TBR=thestig (since this is effectively a reland) > > > BUG=701894 > > > > > > Review-Url: https://codereview.chromium.org/2772503005 > > > Cr-Commit-Position: refs/heads/master@{#459492} > > > Committed: https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47 > > > > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,sbc@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=701894 > > > > Review-Url: https://codereview.chromium.org/2772113002 > > Cr-Commit-Position: refs/heads/master@{#459553} > > Committed: https://chromium.googlesource.com/chromium/src/+/f2296e4fcaef7fdced40ebf3ca736d5dc58c66cd > > TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=701894 > > Review-Url: https://codereview.chromium.org/2776773002 > Cr-Commit-Position: refs/heads/master@{#459584} > Committed: https://chromium.googlesource.com/chromium/src/+/b0d4ad8b38bfaf4c66ab07fdbe892aee8d207bed TBR=thakis@chromium.org,dpranke@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,thomasanderson@google.com,sbc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=701894 Review-Url: https://codereview.chromium.org/2780763002 Cr-Commit-Position: refs/heads/master@{#460070} Committed: https://chromium.googlesource.com/chromium/src/+/75a1434be05f2ef09c307f7b70713385232a5b84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -59 lines) Patch
M build/config/sysroot.gni View 2 chunks +12 lines, -6 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 4 chunks +36 lines, -28 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32_jessie View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 4 chunks +2 lines, -4 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 2 chunks +1 line, -4 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/copyright_scanner/copyright_scanner.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
Created Revert of "Update linux sysroot from Wheezy to Jessie"
3 years, 8 months ago (2017-03-28 09:44:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780763002/1
3 years, 8 months ago (2017-03-28 09:45:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/75a1434be05f2ef09c307f7b70713385232a5b84
3 years, 8 months ago (2017-03-28 12:44:21 UTC) #6
Nico
How long do you think upgrading your bots will take? Several things are blocked on ...
3 years, 8 months ago (2017-03-28 13:02:34 UTC) #7
Michael Achenbach
On 2017/03/28 13:02:34, Nico wrote: > How long do you think upgrading your bots will ...
3 years, 8 months ago (2017-03-28 13:08:48 UTC) #8
Nico
3 years, 8 months ago (2017-03-30 12:27:04 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2783193002/ by thakis@chromium.org.

The reason for reverting is: V8 bots are upgraded..

Powered by Google App Engine
This is Rietveld 408576698