Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2772503005: Reland of "Update linux sysroot from Wheezy to Jessie" (Closed)

Created:
3 years, 9 months ago by Sam Clegg
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang, Dirk Pranke, Nico
CC:
chromium-reviews, ozone-reviews_chromium.org, grt+watch_chromium.org, piman+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org, kalyank, Michael Moss, Tom Anderson, Lei Zhang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Update linux sysroot from Wheezy to Jessie" The last version of this change was: https://codereview.chromium.org/2748183005 Which was reverted in: https://codereview.chromium.org/2776503002 I've updated the expected package deps again, this time being sure to use is_chrome_branded=true when testing (which oddly seems to effect the deps). TBR=thestig (since this is effectively a reland) BUG=701894 Review-Url: https://codereview.chromium.org/2772503005 Cr-Commit-Position: refs/heads/master@{#459492} Committed: https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -72 lines) Patch
M build/config/sysroot.gni View 2 chunks +6 lines, -12 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 4 chunks +25 lines, -33 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32_jessie View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64_jessie View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 2 chunks +4 lines, -1 line 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/copyright_scanner/copyright_scanner.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Sam Clegg
3 years, 9 months ago (2017-03-23 19:57:23 UTC) #5
Nico
lgtm
3 years, 9 months ago (2017-03-23 20:00:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772503005/1
3 years, 9 months ago (2017-03-24 17:40:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/394162)
3 years, 9 months ago (2017-03-24 17:49:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772503005/1
3 years, 9 months ago (2017-03-24 17:54:51 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7f43e46a7830cb92c08b8245f7f48f0d3a2fab47
3 years, 9 months ago (2017-03-24 18:46:38 UTC) #19
Tom Anderson
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2772113002/ by thomasanderson@chromium.org. ...
3 years, 9 months ago (2017-03-24 21:14:25 UTC) #20
Mike Wittman
3 years, 9 months ago (2017-03-24 21:15:31 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2774513006/ by wittman@chromium.org.

The reason for reverting is: Still breaks the Official Linux build, sorry. :(

FAILED: google-chrome-unstable_59.0.3051.0-1_amd64.deb 
python ../../chrome/installer/linux/flock_make_package.py linux_package.lock
installer/debian/build.sh -o . -b . -a x64 -c unstable -d google_chrome -s
/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot
dpkg-shlibdeps: warning: binaries to analyze should already be installed in
their package's directory
---
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/debian/expected_deps_x64_jessie	2017-03-24
12:47:31.781744635 -0700
+++ actual	2017-03-24 14:05:17.485075836 -0700
@@ -4,7 +4,7 @@
 libc6 (>= 2.15)
 libcairo2 (>= 1.6.0)
 libcups2 (>= 1.4.0)
-libdbus-1-3 (>= 1.2.14)
+libdbus-1-3 (>= 1.1.4)
 libexpat1 (>= 2.0.1)
 libfontconfig1 (>= 2.11)
 libfreetype6 (>= 2.3.9)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/debian/expected_deps_ia32_jessie
chrome/installer/linux/debian/expected_deps_ia32_wheezy
chrome/installer/linux/debian/expected_deps_x64_jessie
chrome/installer/linux/debian/expected_deps_x64_wheezy
.

Powered by Google App Engine
This is Rietveld 408576698