Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2782943003: Revert of Disable SPInvalidation by default (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable SPInvalidation by default (patchset #2 id:20001 of https://codereview.chromium.org/2772833003/ ) Reason for revert: Enable SPInvalidation on M59. Original issue's description: > Disable SPInvalidation by default > > We decided to delay launch until M59. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2752673002 > Cr-Commit-Position: refs/heads/master@{#456857} > TBR=nasko@chromium.org (content_features.cc changes SlimmingPaintInvalidation disabled by default) > > Review-Url: https://codereview.chromium.org/2772833003 > Cr-Commit-Position: refs/heads/master@{#459201} > Committed: https://chromium.googlesource.com/chromium/src/+/a038d334a0e1baae632e583dbc023f3383e8bf6f TBR=chrishtr@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2782943003 Cr-Commit-Position: refs/heads/master@{#460521} Committed: https://chromium.googlesource.com/chromium/src/+/eded34c4a1df9950ea622424f2ee9f76ce852213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/child/runtime_features.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
Created Revert of Disable SPInvalidation by default
3 years, 8 months ago (2017-03-29 18:29:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782943003/1
3 years, 8 months ago (2017-03-29 18:30:33 UTC) #3
chrishtr
lgtm
3 years, 8 months ago (2017-03-29 18:31:22 UTC) #4
pdr.
LGTM!
3 years, 8 months ago (2017-03-29 18:32:03 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:29:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eded34c4a1df9950ea622424f2ee...

Powered by Google App Engine
This is Rietveld 408576698