Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2772833003: Disable SPInvalidation by default (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
chrishtr, pdr.
CC:
chromium-reviews, blink-reviews, jam, kinuko+watch, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable SPInvalidation by default We decided to delay launch until M59. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2752673002 Cr-Commit-Position: refs/heads/master@{#456857} TBR=nasko@chromium.org (content_features.cc changes SlimmingPaintInvalidation disabled by default) Review-Url: https://codereview.chromium.org/2772833003 Cr-Commit-Position: refs/heads/master@{#459201} Committed: https://chromium.googlesource.com/chromium/src/+/a038d334a0e1baae632e583dbc023f3383e8bf6f

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/child/runtime_features.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
Xianzhu
The previous disabling didn't work because Chrome controls the feature and enables it by default. ...
3 years, 9 months ago (2017-03-23 16:25:41 UTC) #2
pdr.
On 2017/03/23 at 16:25:41, wangxianzhu wrote: > The previous disabling didn't work because Chrome controls ...
3 years, 9 months ago (2017-03-23 16:41:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772833003/1
3 years, 9 months ago (2017-03-23 16:57:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393000)
3 years, 9 months ago (2017-03-23 17:06:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772833003/1
3 years, 9 months ago (2017-03-23 17:15:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/413375)
3 years, 9 months ago (2017-03-23 18:00:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772833003/20001
3 years, 9 months ago (2017-03-23 18:31:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/346746)
3 years, 9 months ago (2017-03-23 19:06:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772833003/20001
3 years, 9 months ago (2017-03-23 19:13:22 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a038d334a0e1baae632e583dbc023f3383e8bf6f
3 years, 9 months ago (2017-03-23 20:26:34 UTC) #22
Xianzhu
3 years, 8 months ago (2017-03-29 18:29:40 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2782943003/ by wangxianzhu@chromium.org.

The reason for reverting is: Enable SPInvalidation on M59..

Powered by Google App Engine
This is Rietveld 408576698