Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2752673002:
SPInvalidation -> experimental (Closed)
DescriptionSPInvalidation -> experimental
We decided to delay launch until M59.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2752673002
Cr-Commit-Position: refs/heads/master@{#456857}
Committed: https://chromium.googlesource.com/chromium/src/+/d6782e3f3ea554066b359c025cb6dc41fc3c3d3f
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
Description was changed from ========== none BUG= ========== to ========== SPInvalidation -> experimental We decided to delay launch until M9. ==========
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
chrishtr@chromium.org changed reviewers: + pdr@chromium.org, wangxianzhu@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Plan to re-land right after once cherrypicked.
On 2017/03/14 at 20:18:18, chrishtr wrote: > Plan to re-land right after once cherrypicked. You mean reverted? LGTM Please do land with the CQ. I've added CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 too
Description was changed from ========== SPInvalidation -> experimental We decided to delay launch until M9. ========== to ========== SPInvalidation -> experimental We decided to delay launch until M59. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
lgtm
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489524281307620, "parent_rev":
"5edcc960338a8b074127eecfb3d09ba6ab7e7418", "commit_rev":
"d6782e3f3ea554066b359c025cb6dc41fc3c3d3f"}
Message was sent while issue was closed.
Description was changed from ========== SPInvalidation -> experimental We decided to delay launch until M59. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== SPInvalidation -> experimental We decided to delay launch until M59. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2752673002 Cr-Commit-Position: refs/heads/master@{#456857} Committed: https://chromium.googlesource.com/chromium/src/+/d6782e3f3ea554066b359c025cb6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d6782e3f3ea554066b359c025cb6...
Message was sent while issue was closed.
Can you let this be effective on ToT for one or two days? There are so many related and unrelated changes after the last enabling. I would like to compare performance of non-spinvalidation and spinvalidation (except for blink_perf.* which always have experimental features enabled).
Message was sent while issue was closed.
Ok will do. On Tue, Mar 14, 2017 at 5:11 PM, <wangxianzhu@chromium.org> wrote: > Can you let this be effective on ToT for one or two days? There are so many > related and unrelated changes after the last enabling. I would like to > compare > performance of non-spinvalidation and spinvalidation (except for > blink_perf.* > which always have experimental features enabled). > > > https://codereview.chromium.org/2752673002/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Ok will do. On Tue, Mar 14, 2017 at 5:11 PM, <wangxianzhu@chromium.org> wrote: > Can you let this be effective on ToT for one or two days? There are so many > related and unrelated changes after the last enabling. I would like to > compare > performance of non-spinvalidation and spinvalidation (except for > blink_perf.* > which always have experimental features enabled). > > > https://codereview.chromium.org/2752673002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2763033003/ by wangxianzhu@chromium.org. The reason for reverting is: Enable SPInvalidation in M59. We should have got enough performance data for non-SPInvalidation.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
