Chromium Code Reviews
DescriptionReland of Add EnabledStateObserver to BackgroundTracingManager (patchset #1 id:1 of https://codereview.chromium.org/2785663002/ )
Reason for revert:
|config_| can be null. So, do not dereference it.
Original issue's description:
> Revert of Add EnabledStateObserver to BackgroundTracingManager (patchset #3 id:130001 of https://codereview.chromium.org/2769963005/ )
>
> Reason for revert:
> This CL causes tests failures (browser_side_navigation_content_browsertests, content_browsertests, site_per_process_content_browsertests).
>
> https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24171
>
> Original issue's description:
> > Add EnabledStateObserver to BackgroundTracingManager
> >
> > This CL removes the memory-infra related code into memory-tracing
> > observer. Also the tests implement the observer instead of setting
> > callbacks.
> >
> > BUG=700245
> >
> > Review-Url: https://codereview.chromium.org/2769963005
> > Cr-Commit-Position: refs/heads/master@{#460293}
> > Committed: https://chromium.googlesource.com/chromium/src/+/f64ac5cb273e3abab3564f1a5997b3da164ab9ff
>
> TBR=oysteine@chromium.org,alexmos@chromium.org,ssid@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=700245
>
> Review-Url: https://codereview.chromium.org/2785663002
> Cr-Commit-Position: refs/heads/master@{#460343}
> Committed: https://chromium.googlesource.com/chromium/src/+/88d07c763d35621da2c62b9f18822109bbd7a261
TBR=alexmos@chromium.org,kolos@chromium.org
BUG=700245
Review-Url: https://codereview.chromium.org/2782933002
Cr-Commit-Position: refs/heads/master@{#460542}
Committed: https://chromium.googlesource.com/chromium/src/+/eb549628eb3e134f66bebea123a27d89dcf43dbb
Patch Set 1 : Original CL. #Patch Set 2 : Fix #
Dependent Patchsets: Messages
Total messages: 14 (9 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||