Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 2777343003: [memory-infra] Add api to enable heap profiling in MemoryDumpManager

Created:
3 years, 9 months ago by ssid
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-infra] Add api to enable heap profiling in MemoryDumpManager This CL changes: 1. Add ability to enable heap profiling in process without command line flag, by calling MDM::EnableHeapProfiling. 2. Introduce BACKGROUND mode in allocation context tracker. This mode records only thread names and task locations. 3. MDP::OnHeapProfilingEnabled() is not called for task profiler. BUG=700245, 698271

Patch Set 1 : nit. #

Patch Set 2 : nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -27 lines) Patch
M base/trace_event/heap_profiler_allocation_context_tracker.h View 1 chunk +5 lines, -4 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M base/trace_event/malloc_dump_provider.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M base/trace_event/memory_dump_manager.h View 3 chunks +13 lines, -2 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 7 chunks +43 lines, -10 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 3 chunks +73 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (9 generated)
ssid
3 years, 8 months ago (2017-03-28 21:57:26 UTC) #5
ptal, thanks!

Powered by Google App Engine
This is Rietveld 408576698