Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2785663002: Revert of Add EnabledStateObserver to BackgroundTracingManager (Closed)

Created:
3 years, 8 months ago by kolos1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add EnabledStateObserver to BackgroundTracingManager (patchset #3 id:130001 of https://codereview.chromium.org/2769963005/ ) Reason for revert: This CL causes tests failures (browser_side_navigation_content_browsertests, content_browsertests, site_per_process_content_browsertests). https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/24171 Original issue's description: > Add EnabledStateObserver to BackgroundTracingManager > > This CL removes the memory-infra related code into memory-tracing > observer. Also the tests implement the observer instead of setting > callbacks. > > BUG=700245 > > Review-Url: https://codereview.chromium.org/2769963005 > Cr-Commit-Position: refs/heads/master@{#460293} > Committed: https://chromium.googlesource.com/chromium/src/+/f64ac5cb273e3abab3564f1a5997b3da164ab9ff TBR=oysteine@chromium.org,alexmos@chromium.org,ssid@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700245 Review-Url: https://codereview.chromium.org/2785663002 Cr-Commit-Position: refs/heads/master@{#460343} Committed: https://chromium.googlesource.com/chromium/src/+/88d07c763d35621da2c62b9f18822109bbd7a261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -187 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/tracing/background_memory_tracing_observer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D content/browser/tracing/background_memory_tracing_observer.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_browsertest.cc View 5 chunks +17 lines, -54 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.h View 3 chunks +3 lines, -27 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 6 chunks +27 lines, -39 lines 0 comments Download
M content/public/browser/background_tracing_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kolos1
Created Revert of Add EnabledStateObserver to BackgroundTracingManager
3 years, 8 months ago (2017-03-29 10:43:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785663002/1
3 years, 8 months ago (2017-03-29 10:43:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/88d07c763d35621da2c62b9f18822109bbd7a261
3 years, 8 months ago (2017-03-29 10:45:27 UTC) #6
ssid
3 years, 8 months ago (2017-03-29 17:50:20 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2782933002/ by ssid@chromium.org.

The reason for reverting is: |config_| can be null. So, do not dereference it..

Powered by Google App Engine
This is Rietveld 408576698