Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2782553006: Remove SVGTests.requiredFeatures attribute (Closed)

Created:
3 years, 8 months ago by riju_
Modified:
3 years, 8 months ago
Reviewers:
fs, timvolodine, foolip
CC:
chromium-reviews, krit, rwlbuis, fmalita+watch_chromium.org, mac-reviews_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, android-webview-reviews_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGTests.requiredFeatures attribute In SVG2, hasFeature always return true. So requiredFeatures attribute not doing anything useful. It has been removed from the spec: https://github.com/w3c/svgwg/commit/9a30d01f6410dc516c5f874d71e957230a3448cd https://www.w3.org/2015/06/09-svg-irc#T15-35-40 Intent to Deprecate : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qiFyionxCYg BUG=635420 Review-Url: https://codereview.chromium.org/2782553006 Cr-Commit-Position: refs/heads/master@{#461065} Committed: https://chromium.googlesource.com/chromium/src/+/3bc8c04a9e2e711079299a591fa9eadc56b09729

Patch Set 1 #

Patch Set 2 : Rebaselining removes historical-expected.txt #

Total comments: 2

Patch Set 3 : foolip's comment #

Messages

Total messages: 18 (9 generated)
riju_
Hi Federick and Philip, I uploaded this new CL based on https://codereview.chromium.org/2741463002/ I can change ...
3 years, 8 months ago (2017-03-29 11:13:03 UTC) #2
fs
On 2017/03/29 at 11:13:03, rijubrata.bhaumik wrote: > Hi Federick and Philip, > > I uploaded ...
3 years, 8 months ago (2017-03-29 11:23:47 UTC) #3
foolip
lgtm % removing the content attribute fully https://codereview.chromium.org/2782553006/diff/20001/third_party/WebKit/Source/core/svg/SVGTests.cpp File third_party/WebKit/Source/core/svg/SVGTests.cpp (right): https://codereview.chromium.org/2782553006/diff/20001/third_party/WebKit/Source/core/svg/SVGTests.cpp#newcode76 third_party/WebKit/Source/core/svg/SVGTests.cpp:76: return attrName ...
3 years, 8 months ago (2017-03-30 05:09:50 UTC) #5
riju_
@Tim : please review android_webview/ changes. https://codereview.chromium.org/2782553006/diff/20001/third_party/WebKit/Source/core/svg/SVGTests.cpp File third_party/WebKit/Source/core/svg/SVGTests.cpp (right): https://codereview.chromium.org/2782553006/diff/20001/third_party/WebKit/Source/core/svg/SVGTests.cpp#newcode76 third_party/WebKit/Source/core/svg/SVGTests.cpp:76: return attrName == ...
3 years, 8 months ago (2017-03-30 07:00:09 UTC) #7
timvolodine
On 2017/03/30 07:00:09, riju_ wrote: > @Tim : please review android_webview/ changes. android_webview/.. -- lgtm
3 years, 8 months ago (2017-03-30 16:12:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782553006/40001
3 years, 8 months ago (2017-03-30 18:02:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/394960) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 8 months ago (2017-03-30 18:46:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782553006/40001
3 years, 8 months ago (2017-03-31 05:47:29 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 07:15:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3bc8c04a9e2e711079299a591fa9...

Powered by Google App Engine
This is Rietveld 408576698