Remove SVGTests.requiredFeatures attribute

Remove SVGTests.requiredFeatures attribute

In SVG2, hasFeature always return true.
So requiredFeatures attribute not doing anything useful.

It has been removed from the spec:
https://github.com/w3c/svgwg/commit/9a30d01f6410dc516c5f874d71e957230a3448cd
https://www.w3.org/2015/06/09-svg-irc#T15-35-40

Remove layout tests for requiredFeature

BUG=635420

[riju_, 2017-03-08 08:22:33]

The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 08:23:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 09:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 09:18:31]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[riju_, 2017-03-08 10:02:24]

Description was changed from

==========
Remove SVGTests.requiredFeatures attribute

In SVG2, hasFeature always return true.
So requiredFeatures attribute not doing anything useful.

It has been removed from the spec:
https://github.com/w3c/svgwg/commit/9a30d01f6410dc516c5f874d71e957230a3448cd
https://www.w3.org/2015/06/09-svg-irc#T15-35-40

Remove layout tests for requiredFeature
remove hasFeature

BUG=635420
==========

to

==========
Remove SVGTests.requiredFeatures attribute

In SVG2, hasFeature always return true.
So requiredFeatures attribute not doing anything useful.

It has been removed from the spec:
https://github.com/w3c/svgwg/commit/9a30d01f6410dc516c5f874d71e957230a3448cd
https://www.w3.org/2015/06/09-svg-irc#T15-35-40

Remove layout tests for requiredFeature

BUG=635420
==========

[riju_, 2017-03-08 10:03:37]

The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 10:03:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 11:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 11:12:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[riju_, 2017-03-08 11:37:55]

Patchset #3 (id:40001) has been deleted

[riju_, 2017-03-08 12:57:13]

The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 12:57:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 13:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 13:44:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[riju_, 2017-03-09 15:40:15]

The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 15:40:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 17:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:15:05]

Dry run: This issue passed the CQ dry run.

[riju_, 2017-03-23 15:50:19]

The CQ bit was checked by rijubrata.bhaumik@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 15:50:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[riju_, 2017-03-23 16:28:16]

rijubrata.bhaumik@intel.com changed reviewers:
+ fs@opera.com

[riju_, 2017-03-23 16:28:17]

Hi Fredrick, 

Can you take a look?
I will send an Intent to deprecate/remove soon.

[commit-bot: I haz the power, 2017-03-23 16:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 16:50:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fs, 2017-03-23 16:55:44]

For all tests that can be rewritten to not use requiredFeatures, let's do that
rewrite as a separate CL and land that before this one. (No need to wait for the
intent-dance to complete before doing that either.)

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/external/wpt/svg/interfaces.html (left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/svg/interfaces.html:1435:
SVGStringList: ['a.requiredFeatures'],
You should find a SVGStringList elsewhere instead of removing this I think.

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/platform/mac-retina/virtual/stable/webexposed/global-interface-listing-expected.txt
(right):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/platform/mac-retina/virtual/stable/webexposed/global-interface-listing-expected.txt:1:
CONSOLE WARNING: line 95: 'webkitURL' is deprecated. Please use 'URL' instead.
Why didn't this file get de-duplicated? (I.e how does the different target
platforms differ?)

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/platform/win/external/wpt/svg/interfaces-expected.txt
(right):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/platform/win/external/wpt/svg/interfaces-expected.txt:1:
CONSOLE MESSAGE: line 251: callback not yet supported
Ditto.

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
(left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg:135: new
Subtest("i.requiredFeatures.numberOfItems == 0"),
Either replace this to use a different SVGStringList attribute, or leave it as
is.

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg
(left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f.svg:1: <svg
id="svg-root" width="100%" height="100%"
I guess we could remove this test because SVGStringList-basics (rewritten)
should hopefully provide the the same coverage. Please double-check that before
removing though.

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/struct-image-02-b.svg
(left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1/struct-image-02-b.svg:98: <rect
fill="red"  x="240" y="150" width="240" height="150"
requiredFeatures="org.w3c.svg.static" systemLanguage=""/>
Just keep these as is and update the expected results instead (if they differ.)

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/svg/animations/animate-test-attributes-crash.html
(left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/animations/animate-test-attributes-crash.html:3:
<animate attributeName="requiredFeatures"/>
This test could be left as is. (This is still an attribute that can't be
animated.)

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/custom/text-use-click-crash.xhtml
(left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/custom/text-use-click-crash.xhtml:1: <html
xmlns="http://www.w3.org/1999/xhtml">
I don't see a need to remove this test.

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/SVGStringList-basics.xhtml (left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/SVGStringList-basics.xhtml:18:
shouldBe("text1.requiredFeatures.numberOfItems", "3");
Ditto.

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGStringList.js
(left):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/svg/dom/script-tests/SVGStringList.js:1:
description("This test checks the SVGStringList API - utilizing the
requiredFeatures property of SVGRectElement");
This test should be rewritten to use another SVGStringList (we can do that and
land it before doing the removal.) It would probably make sense to just merge
this with the SVGStringList-basics test though.

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGTests.cpp (right):

https://codereview.chromium.org/2741463002/diff/90001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGTests.cpp:57: // No need to check
requiredFeatures since hasFeature always returns true.
Nit: Remove this comment (and the blank line following it) as well.