Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: third_party/WebKit/Source/core/svg/SVGTests.cpp

Issue 2782553006: Remove SVGTests.requiredFeatures attribute (Closed)
Patch Set: foolip's comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTests.h ('k') | third_party/WebKit/Source/core/svg/SVGTests.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGTests.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGTests.cpp b/third_party/WebKit/Source/core/svg/SVGTests.cpp
index 92ff15e0e25e8758d289c67c2eb7fb8fbcdf42aa..5377735b919272fe4022fb1a3771db45151078d7 100644
--- a/third_party/WebKit/Source/core/svg/SVGTests.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGTests.cpp
@@ -28,10 +28,7 @@
namespace blink {
SVGTests::SVGTests(SVGElement* contextElement)
- : m_requiredFeatures(
- SVGStaticStringList::create(contextElement,
- SVGNames::requiredFeaturesAttr)),
- m_requiredExtensions(
+ : m_requiredExtensions(
SVGStaticStringList::create(contextElement,
SVGNames::requiredExtensionsAttr)),
m_systemLanguage(
@@ -39,21 +36,15 @@ SVGTests::SVGTests(SVGElement* contextElement)
SVGNames::systemLanguageAttr)) {
DCHECK(contextElement);
- contextElement->addToPropertyMap(m_requiredFeatures);
contextElement->addToPropertyMap(m_requiredExtensions);
contextElement->addToPropertyMap(m_systemLanguage);
}
DEFINE_TRACE(SVGTests) {
- visitor->trace(m_requiredFeatures);
visitor->trace(m_requiredExtensions);
visitor->trace(m_systemLanguage);
}
-SVGStringListTearOff* SVGTests::requiredFeatures() {
- return m_requiredFeatures->tearOff();
-}
-
SVGStringListTearOff* SVGTests::requiredExtensions() {
return m_requiredExtensions->tearOff();
}
@@ -63,8 +54,6 @@ SVGStringListTearOff* SVGTests::systemLanguage() {
}
bool SVGTests::isValid() const {
- // No need to check requiredFeatures since hasFeature always returns true.
-
if (m_systemLanguage->isSpecified()) {
bool matchFound = false;
for (const auto& value : m_systemLanguage->value()->values()) {
@@ -84,8 +73,7 @@ bool SVGTests::isValid() const {
}
bool SVGTests::isKnownAttribute(const QualifiedName& attrName) {
- return attrName == SVGNames::requiredFeaturesAttr ||
- attrName == SVGNames::requiredExtensionsAttr ||
+ return attrName == SVGNames::requiredExtensionsAttr ||
attrName == SVGNames::systemLanguageAttr;
}
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGTests.h ('k') | third_party/WebKit/Source/core/svg/SVGTests.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698