Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2782143002:
Reland of [Android] Respect animation multiplier from Developer Options. (Closed)
|
Created:
3 years, 8 months ago by Bernhard Bauer Modified:
3 years, 8 months ago Reviewers:
mdjones CC:
chromium-reviews, agrieve+watch_chromium.org, aelias_OOO_until_Jul13 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/)
ChromeAnimation can now correctly deal with animations of length 0.
Originally reviewed at https://codereview.chromium.org/2743403006.
BUG=706069
Review-Url: https://codereview.chromium.org/2782143002
Cr-Commit-Position: refs/heads/master@{#460711}
Committed: https://chromium.googlesource.com/chromium/src/+/4f8d0b3cdb5c51733c3c0f63dfb0b17dac7b9bff
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : remove assert #Messages
Total messages: 16 (11 generated)
Created Reland of [Android] Respect animation multiplier from Developer Options.
Description was changed from ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/ ) Reason for revert: Reland Original issue's description: > Revert of [Android] Respect animation multiplier from Developer Options. (patchset #3 id:40001 of https://codereview.chromium.org/2743403006/ ) > > Reason for revert: > Breaks the tab switcher when scale is set to zero. > > BUG=706069 > > Original issue's description: > > [Android] Respect animation multiplier from Developer Options. > > > > Review-Url: https://codereview.chromium.org/2743403006 > > Cr-Commit-Position: refs/heads/master@{#457284} > > Committed: https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eac... > > TBR=mdjones@chromium.org,bauerb@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Review-Url: https://codereview.chromium.org/2782013002 > Cr-Commit-Position: refs/heads/master@{#460260} > Committed: https://chromium.googlesource.com/chromium/src/+/bb76338abd7a35297065ceb7d3aa... TBR=mdjones@chromium.org,aelias@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706069 ========== to ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/ ) Original issue's description: > Revert of [Android] Respect animation multiplier from Developer Options. (patchset #3 id:40001 of https://codereview.chromium.org/2743403006/ ) > > Reason for revert: > Breaks the tab switcher when scale is set to zero. > > BUG=706069 > > Original issue's description: > > [Android] Respect animation multiplier from Developer Options. > > > > Review-Url: https://codereview.chromium.org/2743403006 > > Cr-Commit-Position: refs/heads/master@{#457284} > > Committed: https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eac... > > TBR=mdjones@chromium.org,bauerb@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Review-Url: https://codereview.chromium.org/2782013002 > Cr-Commit-Position: refs/heads/master@{#460260} > Committed: https://chromium.googlesource.com/chromium/src/+/bb76338abd7a35297065ceb7d3aa... BUG=706069 ==========
Description was changed from ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/ ) Original issue's description: > Revert of [Android] Respect animation multiplier from Developer Options. (patchset #3 id:40001 of https://codereview.chromium.org/2743403006/ ) > > Reason for revert: > Breaks the tab switcher when scale is set to zero. > > BUG=706069 > > Original issue's description: > > [Android] Respect animation multiplier from Developer Options. > > > > Review-Url: https://codereview.chromium.org/2743403006 > > Cr-Commit-Position: refs/heads/master@{#457284} > > Committed: https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eac... > > TBR=mdjones@chromium.org,bauerb@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > > Review-Url: https://codereview.chromium.org/2782013002 > Cr-Commit-Position: refs/heads/master@{#460260} > Committed: https://chromium.googlesource.com/chromium/src/+/bb76338abd7a35297065ceb7d3aa... BUG=706069 ========== to ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/ ) Originally reviewed at https://codereview.chromium.org/2743403006. BUG=706069 ==========
bauerb@chromium.org changed reviewers: - aelias@chromium.org
Description was changed from ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/ ) Originally reviewed at https://codereview.chromium.org/2743403006. BUG=706069 ========== to ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/) ChromeAnimation can now correctly deal with animations of length 0. Originally reviewed at https://codereview.chromium.org/2743403006. BUG=706069 ==========
The CQ bit was checked by bauerb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please review. The original change is in patch set 1, for comparison.
lgtm
The CQ bit was checked by bauerb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490865613712700,
"parent_rev": "8202d740b1c09787cdd3e11d3d15e7211b88f15e", "commit_rev":
"4f8d0b3cdb5c51733c3c0f63dfb0b17dac7b9bff"}
Message was sent while issue was closed.
Description was changed from ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/) ChromeAnimation can now correctly deal with animations of length 0. Originally reviewed at https://codereview.chromium.org/2743403006. BUG=706069 ========== to ========== Reland of [Android] Respect animation multiplier from Developer Options. (patchset #1 id:1 of https://codereview.chromium.org/2782013002/) ChromeAnimation can now correctly deal with animations of length 0. Originally reviewed at https://codereview.chromium.org/2743403006. BUG=706069 Review-Url: https://codereview.chromium.org/2782143002 Cr-Commit-Position: refs/heads/master@{#460711} Committed: https://chromium.googlesource.com/chromium/src/+/4f8d0b3cdb5c51733c3c0f63dfb0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/4f8d0b3cdb5c51733c3c0f63dfb0... |
