Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2782013002: Revert of [Android] Respect animation multiplier from Developer Options. (Closed)

Created:
3 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 8 months ago
Reviewers:
mdjones, Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Respect animation multiplier from Developer Options. (patchset #3 id:40001 of https://codereview.chromium.org/2743403006/ ) Reason for revert: Breaks the tab switcher when scale is set to zero. BUG=706069 Original issue's description: > [Android] Respect animation multiplier from Developer Options. > > Review-Url: https://codereview.chromium.org/2743403006 > Cr-Commit-Position: refs/heads/master@{#457284} > Committed: https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eacf4677bda6954 TBR=mdjones@chromium.org,bauerb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2782013002 Cr-Commit-Position: refs/heads/master@{#460260} Committed: https://chromium.googlesource.com/chromium/src/+/bb76338abd7a35297065ceb7d3aaecc8a3dd1bae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java View 3 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
aelias_OOO_until_Jul13
Created Revert of [Android] Respect animation multiplier from Developer Options.
3 years, 8 months ago (2017-03-28 22:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782013002/1
3 years, 8 months ago (2017-03-28 22:16:41 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/259696)
3 years, 8 months ago (2017-03-29 00:04:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782013002/1
3 years, 8 months ago (2017-03-29 00:07:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 00:18:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782013002/1
3 years, 8 months ago (2017-03-29 00:22:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bb76338abd7a35297065ceb7d3aaecc8a3dd1bae
3 years, 8 months ago (2017-03-29 01:55:30 UTC) #14
Bernhard Bauer
3 years, 8 months ago (2017-03-29 10:23:53 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2782143002/ by bauerb@chromium.org.

The reason for reverting is: Reland.

Powered by Google App Engine
This is Rietveld 408576698