[Android] Respect animation multiplier from Developer Options.

[Android] Respect animation multiplier from Developer Options.

Review-Url: https://codereview.chromium.org/2743403006
Cr-Commit-Position: refs/heads/master@{#457284}
Committed: https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eacf4677bda6954

[Bernhard Bauer, 2017-03-15 17:11:25]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 17:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2017-03-15 18:25:08]

bauerb@chromium.org changed reviewers:
+ mdjones@chromium.org

[Bernhard Bauer, 2017-03-15 18:25:08]

Please review. Thanks!

[mdjones, 2017-03-15 20:50:39]

lgtm

https://codereview.chromium.org/2743403006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java
(right):

https://codereview.chromium.org/2743403006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java:42:
private static Float sAnimationMultiplier;
I'm guessing this can't be final because it is set in a function called by the
constructor rather than directly by the constructor, right?

[Bernhard Bauer, 2017-03-15 21:21:58]

Thanks!

https://codereview.chromium.org/2743403006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java
(right):

https://codereview.chromium.org/2743403006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java:42:
private static Float sAnimationMultiplier;
On 2017/03/15 20:50:38, mdjones wrote:
> I'm guessing this can't be final because it is set in a function called by the
> constructor rather than directly by the constructor, right?

It's static, so it would have to be set when the class is loaded, and I don't
really want to have to rely on ContextUtils being initialized at that point.
What I could do is use the initialization-on-demand holder idiom?

[mdjones, 2017-03-15 22:13:12]

https://codereview.chromium.org/2743403006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java
(right):

https://codereview.chromium.org/2743403006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ChromeAnimation.java:42:
private static Float sAnimationMultiplier;
On 2017/03/15 21:21:58, Bernhard Bauer wrote:
> On 2017/03/15 20:50:38, mdjones wrote:
> > I'm guessing this can't be final because it is set in a function called by
the
> > constructor rather than directly by the constructor, right?
> 
> It's static, so it would have to be set when the class is loaded, and I don't
> really want to have to rely on ContextUtils being initialized at that point.
> What I could do is use the initialization-on-demand holder idiom?

Ah right. I think what you have is fine.

[Bernhard Bauer, 2017-03-15 23:09:58]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:10:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:34:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489619398157310,
"parent_rev": "ec33def4335bb0b84d81a75fafac70d2acc6b280", "commit_rev":
"6020d58dc2052d5bfc6ec36f8eacf4677bda6954"}

[commit-bot: I haz the power, 2017-03-16 00:34:52]

Description was changed from

==========
[Android] Respect animation multiplier from Developer Options.
==========

to

==========
[Android] Respect animation multiplier from Developer Options.

Review-Url: https://codereview.chromium.org/2743403006
Cr-Commit-Position: refs/heads/master@{#457284}
Committed:
https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eac...
==========

[commit-bot: I haz the power, 2017-03-16 00:34:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6020d58dc2052d5bfc6ec36f8eac...

[aelias_OOO_until_Jul13, 2017-03-28 22:16:10]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2782013002/ by aelias@chromium.org.

The reason for reverting is: Breaks the tab switcher when scale is set to zero.

BUG=706069.