Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2782063003: Remove redundant WebLocalFrame* parameter from runScriptsAtDocumentReady (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/LocalFrameClientImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 391
392 // The icon for the page have changed. 392 // The icon for the page have changed.
393 virtual void didChangeIcon(WebLocalFrame*, WebIconURL::Type) {} 393 virtual void didChangeIcon(WebLocalFrame*, WebIconURL::Type) {}
394 394
395 // The frame's document finished loading. 395 // The frame's document finished loading.
396 // This method may not execute JavaScript code. 396 // This method may not execute JavaScript code.
397 virtual void didFinishDocumentLoad(WebLocalFrame*) {} 397 virtual void didFinishDocumentLoad(WebLocalFrame*) {}
398 398
399 // Like |didFinishDocumentLoad|, except this method may run JavaScript 399 // Like |didFinishDocumentLoad|, except this method may run JavaScript
400 // code (and possibly invalidate the frame). 400 // code (and possibly invalidate the frame).
401 virtual void runScriptsAtDocumentReady(WebLocalFrame*, bool documentIsEmpty) { 401 virtual void runScriptsAtDocumentReady(bool documentIsEmpty) {}
402 }
403 402
404 // The frame's window.onload event is ready to fire. This method may delay 403 // The frame's window.onload event is ready to fire. This method may delay
405 // window.onload by incrementing LoadEventDelayCount. 404 // window.onload by incrementing LoadEventDelayCount.
406 virtual void runScriptsAtDocumentIdle(WebLocalFrame*) {} 405 virtual void runScriptsAtDocumentIdle(WebLocalFrame*) {}
407 406
408 // The 'load' event was dispatched. 407 // The 'load' event was dispatched.
409 virtual void didHandleOnloadEvents(WebLocalFrame*) {} 408 virtual void didHandleOnloadEvents(WebLocalFrame*) {}
410 409
411 // The frame's document or one of its subresources failed to load. The 410 // The frame's document or one of its subresources failed to load. The
412 // WebHistoryCommitType is the commit type that would have been used had the 411 // WebHistoryCommitType is the commit type that would have been used had the
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 // Overwrites the given URL to use an HTML5 embed if possible. 758 // Overwrites the given URL to use an HTML5 embed if possible.
760 // An empty URL is returned if the URL is not overriden. 759 // An empty URL is returned if the URL is not overriden.
761 virtual WebURL overrideFlashEmbedWithHTML(const WebURL& url) { 760 virtual WebURL overrideFlashEmbedWithHTML(const WebURL& url) {
762 return WebURL(); 761 return WebURL();
763 } 762 }
764 }; 763 };
765 764
766 } // namespace blink 765 } // namespace blink
767 766
768 #endif 767 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/LocalFrameClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698