Remove redundant WebLocalFrame* parameter from didCreateNewDocument

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 3762 matching lines @@
   // navigation without valid HistoryItem state, WebCore will think it is a
   // new navigation.
   navigation_state->set_request_committed(true);
 
   SendDidCommitProvisionalLoad(frame, commit_type);
 
   // Check whether we have new encoding name.
   UpdateEncoding(frame, frame->view()->pageEncoding().utf8());
 }
 
-void RenderFrameImpl::didCreateNewDocument(blink::WebLocalFrame* frame) {
-  DCHECK(!frame_ || frame_ == frame);

[jochen (gone - plz use gerrit), 2017/03/30 11:44:22]

maybe keep DCHECK(frame_) for a while?

[jochen (gone - plz use gerrit), 2017/03/30 11:49:58]

on second thought, please first verify a while with DCHECK_EQ(frame_, frame).
You deref frame_ below and if it can be nullptr while frame is not, this change
is not safe (so not lgtm for now)

-
+void RenderFrameImpl::didCreateNewDocument() {
   for (auto& observer : observers_)
     observer.DidCreateNewDocument();
   for (auto& observer : render_view_->observers())
-    observer.DidCreateNewDocument(frame);
+    observer.DidCreateNewDocument(frame_);
 }
 
 void RenderFrameImpl::didClearWindowObject(blink::WebLocalFrame* frame) {
   DCHECK_EQ(frame_, frame);
 
   if (enabled_bindings_ & BINDINGS_POLICY_WEB_UI)
     WebUIExtension::Install(frame);
 
   if (enabled_bindings_ & BINDINGS_POLICY_DOM_AUTOMATION)
     DomAutomationController::Install(this, frame);
@@ skipping 3169 matching lines @@
       policy(info.defaultPolicy),
       replaces_current_history_item(info.replacesCurrentHistoryItem),
       history_navigation_in_new_child_frame(
           info.isHistoryNavigationInNewChildFrame),
       client_redirect(info.isClientRedirect),
       cache_disabled(info.isCacheDisabled),
       form(info.form),
       source_location(info.sourceLocation) {}
 
 }  // namespace content