Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2781993004: Remove redundant WebLocalFrame* parameter from didCreateNewDocument (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 679773f82aca83ced3397903a82c2e4dd7c899e6..44d1f38659bd3eb3d92385b9a9c3a7c86e474cbf 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3780,13 +3780,11 @@ void RenderFrameImpl::didCommitProvisionalLoad(
UpdateEncoding(frame, frame->view()->pageEncoding().utf8());
}
-void RenderFrameImpl::didCreateNewDocument(blink::WebLocalFrame* frame) {
- DCHECK(!frame_ || frame_ == frame);
jochen (gone - plz use gerrit) 2017/03/30 11:44:22 maybe keep DCHECK(frame_) for a while?
jochen (gone - plz use gerrit) 2017/03/30 11:49:58 on second thought, please first verify a while wit
-
+void RenderFrameImpl::didCreateNewDocument() {
for (auto& observer : observers_)
observer.DidCreateNewDocument();
for (auto& observer : render_view_->observers())
- observer.DidCreateNewDocument(frame);
+ observer.DidCreateNewDocument(frame_);
}
void RenderFrameImpl::didClearWindowObject(blink::WebLocalFrame* frame) {
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698