Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2781533002: Fix range check error by replacing invalid .size with .length. (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix range check error by replacing invalid .size with .length. Also fixed presumable off-by-one errors. BUG=705527 TEST=try CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2781533002 Cr-Commit-Position: refs/heads/master@{#460079} Committed: https://chromium.googlesource.com/chromium/src/+/1a3aebe1689f7e9759d97bc0cdb1e7f27b7ce02a

Patch Set 1 #

Patch Set 2 : Fix presumable off-by-one error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/webui/resources/js/cr/ui/table/table_column_model.js View 1 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
oka
Fix presumable off-by-one error.
3 years, 9 months ago (2017-03-27 14:32:48 UTC) #5
oka
PTAL.
3 years, 9 months ago (2017-03-27 22:19:29 UTC) #11
Dan Beam
lgtm
3 years, 9 months ago (2017-03-27 23:14:01 UTC) #12
commit-bot: I haz the power
This CL has an open dependency (Issue 2768373003 Patch 40001). Please resolve the dependency and ...
3 years, 8 months ago (2017-03-28 00:51:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781533002/20001
3 years, 8 months ago (2017-03-28 13:15:15 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 13:19:53 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a3aebe1689f7e9759d97bc0cdb1...

Powered by Google App Engine
This is Rietveld 408576698