Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2768373003: Compile more files app targets in gyp v2 (5) (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile more files app targets in gyp v2 (5) BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2768373003 Cr-Commit-Position: refs/heads/master@{#459968} Committed: https://chromium.googlesource.com/chromium/src/+/70eb969b7713def48c0a3c865ea3dd0ba8ee1169

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 1 chunk +17 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 1 2 1 chunk +18 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
oka
.
3 years, 9 months ago (2017-03-24 06:28:01 UTC) #2
oka
PTAL.
3 years, 9 months ago (2017-03-24 06:28:37 UTC) #4
fukino
lgtm
3 years, 9 months ago (2017-03-24 08:21:15 UTC) #5
oka
.
3 years, 9 months ago (2017-03-24 08:37:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768373003/40001
3 years, 9 months ago (2017-03-28 00:52:50 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 01:26:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/70eb969b7713def48c0a3c865ea3...

Powered by Google App Engine
This is Rietveld 408576698