Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2781483004: Stop considering parameter count for methods blocked via --method-blocklist. (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 8 months ago
Reviewers:
danakj, nasko
CC:
chromium-reviews, Ɓukasz Anforowicz
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop considering parameter count for methods blocked via --method-blocklist. BUG=673039 Review-Url: https://codereview.chromium.org/2781483004 Cr-Commit-Position: refs/heads/master@{#460125} Committed: https://chromium.googlesource.com/chromium/src/+/ba5cc8e55eacf6fc90a8504c34aff210ae82f7f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -80 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 3 chunks +11 lines, -32 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/blocked_methods.txt View 1 chunk +6 lines, -10 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc View 1 chunk +5 lines, -19 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/tests/methods-original.cc View 1 chunk +5 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
Cloned from https://codereview.chromium.org/2655543002/ and rebased for landing. Unfortunately, I don't know the original base revision, ...
3 years, 9 months ago (2017-03-27 21:03:16 UTC) #1
dcheng
(Actually send it to reviewers this time)
3 years, 9 months ago (2017-03-27 21:03:42 UTC) #3
danakj
LGTM
3 years, 8 months ago (2017-03-28 16:10:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781483004/1
3 years, 8 months ago (2017-03-28 16:16:46 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 16:40:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ba5cc8e55eacf6fc90a8504c34af...

Powered by Google App Engine
This is Rietveld 408576698