Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2781483004: Stop considering parameter count for methods blocked via --method-blocklist. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
index cc9d57a5ba949cdd5288709df1d8a311838c1bab..5441724ecf1233fcd8419cb6ac0e8cd08b40f171 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-original.cc
@@ -309,36 +309,22 @@ class InternalClass {
// Tests for --method-blocklist cmdline parameter.
class IdlTestClass {
public:
- static int idlTestMethodNoParams(char x) { return 123; }
- static int idlTestMethodOneParam(char x) { return 123; }
+ static int notBlocklistedMethod() { return 123; }
+ int notBlocklistedMethod(int x) { return 123; }
- int idlTestMethodNoParams() { return 123; }
- int idlTestMethodNoParams(int x) { return 123; }
-
- int idlTestMethodOneParam() { return 123; }
- int idlTestMethodOneParam(int x) { return 123; }
-
- int idlTestMethodTwoOrThreeParams() { return 123; }
- int idlTestMethodTwoOrThreeParams(int x, int y) { return 123; }
- int idlTestMethodTwoOrThreeParams(int x, int y, int z) { return 123; }
-
- int idlOptionalArgsPass(int x = 0) { return x; }
- int idlOptionalArgsStillTooMany(int x, int y = 0) { return x + y; }
- int idlOptionalArgsTooLittle(int x = 0) { return x; }
+ static int idlStaticMethod() { return 123; }
+ int idlInstanceMethod() { return 123; }
template <typename T>
int idlTemplateMethod(T x) {
return 123;
}
-
- int path() { return 123; }
- int path(int x) { return 123; }
};
template <typename T>
class IdlTemplateClass {
public:
- int idlTestMethod(T x) { return 123; }
+ int idlInstanceMethod(T x) { return 123; }
};
} // namespace blink
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698