Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc

Issue 2781483004: Stop considering parameter count for methods blocked via --method-blocklist. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
index f79e32178de7a669256d2977fd0ba3025d9dd31f..c11f92291fc5daa93f7bb71993f6ff90922239d6 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc
@@ -305,36 +305,22 @@ class InternalClass {
// Tests for --method-blocklist cmdline parameter.
class IdlTestClass {
public:
- static int IdlTestMethodNoParams(char x) { return 123; }
- static int idlTestMethodOneParam(char x) { return 123; }
+ static int NotBlocklistedMethod() { return 123; }
+ int NotBlocklistedMethod(int x) { return 123; }
- int idlTestMethodNoParams() { return 123; }
- int IdlTestMethodNoParams(int x) { return 123; }
-
- int IdlTestMethodOneParam() { return 123; }
- int idlTestMethodOneParam(int x) { return 123; }
-
- int IdlTestMethodTwoOrThreeParams() { return 123; }
- int idlTestMethodTwoOrThreeParams(int x, int y) { return 123; }
- int idlTestMethodTwoOrThreeParams(int x, int y, int z) { return 123; }
-
- int idlOptionalArgsPass(int x = 0) { return x; }
- int IdlOptionalArgsStillTooMany(int x, int y = 0) { return x + y; }
- int IdlOptionalArgsTooLittle(int x = 0) { return x; }
+ static int idlStaticMethod() { return 123; }
+ int idlInstanceMethod() { return 123; }
template <typename T>
int idlTemplateMethod(T x) {
return 123;
}
-
- int path() { return 123; }
- int GetPath(int x) { return 123; }
};
template <typename T>
class IdlTemplateClass {
public:
- int idlTestMethod(T x) { return 123; }
+ int idlInstanceMethod(T x) { return 123; }
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698