Remove unnecessary calls to std::basic_string<>::c_str()

Remove unnecessary calls to std::basic_string<>::c_str()

It's better not to pass a |const char*| to function which takes a
std::string or base::StringPiece object to avoid calling strlen()
and string copying.

BUG=679479
Review-Url: https://codereview.chromium.org/2781443005
Cr-Commit-Position: refs/heads/master@{#460201}
Committed: https://chromium.googlesource.com/chromium/src/+/020e2a0cb30f9e65d7e52c620a73e0806bcd7109

[Andrey Kraynov, 2017-03-28 17:33:47]

iceman@yandex-team.ru changed reviewers:
+ asargent@chromium.org

[Andrey Kraynov, 2017-03-28 17:33:47]

Hi!

This CL is a continuation of my previous patch,
https://codereview.chromium.org/2624583002/
Could you take a look please?

Also it is not clear to me, who can be a reviewer for
extensions/api/preference/* files.
Could you recommend someone please?

[asargent_no_longer_on_chrome, 2017-03-28 17:45:06]

asargent@chromium.org changed reviewers:
+ lazyboy@chromium.org

[asargent_no_longer_on_chrome, 2017-03-28 17:45:07]

(removing myself as reviewer and punting to lazyboy since I'm no longer working
on chrome)

[asargent_no_longer_on_chrome, 2017-03-28 17:45:19]

Description was changed from

==========
Remove unnecessary calls to std::basic_string<>::c_str()

It's better not to pass a |const char*| to function which takes a
std::string or base::StringPiece object to avoid calling strlen()
and string copying.

BUG=679479
==========

to

==========
Remove unnecessary calls to std::basic_string<>::c_str()

It's better not to pass a |const char*| to function which takes a
std::string or base::StringPiece object to avoid calling strlen()
and string copying.

BUG=679479
==========

[asargent_no_longer_on_chrome, 2017-03-28 17:45:19]

asargent@chromium.org changed reviewers:
- asargent@chromium.org

[lazyboy, 2017-03-28 18:00:10]

lgtm

[Andrey Kraynov, 2017-03-28 18:26:34]

The CQ bit was checked by iceman@yandex-team.ru

[commit-bot: I haz the power, 2017-03-28 18:27:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 18:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 18:40:15]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Andrey Kraynov, 2017-03-28 19:40:56]

On 2017/03/28 18:40:15, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

It seems failures are unrelated to my changes.

[Andrey Kraynov, 2017-03-28 19:41:05]

The CQ bit was checked by iceman@yandex-team.ru

[commit-bot: I haz the power, 2017-03-28 19:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 20:18:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490730065914480, "parent_rev":
"ac0db0c0784da2106c18be21615659ed4cc25c18", "commit_rev":
"020e2a0cb30f9e65d7e52c620a73e0806bcd7109"}

[commit-bot: I haz the power, 2017-03-28 20:20:06]

Description was changed from

==========
Remove unnecessary calls to std::basic_string<>::c_str()

It's better not to pass a |const char*| to function which takes a
std::string or base::StringPiece object to avoid calling strlen()
and string copying.

BUG=679479
==========

to

==========
Remove unnecessary calls to std::basic_string<>::c_str()

It's better not to pass a |const char*| to function which takes a
std::string or base::StringPiece object to avoid calling strlen()
and string copying.

BUG=679479

Review-Url: https://codereview.chromium.org/2781443005
Cr-Commit-Position: refs/heads/master@{#460201}
Committed:
https://chromium.googlesource.com/chromium/src/+/020e2a0cb30f9e65d7e52c620a73...
==========

[commit-bot: I haz the power, 2017-03-28 20:20:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/020e2a0cb30f9e65d7e52c620a73...