chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 2781443005: Remove unnecessary calls to std::basic_string<>::c_str()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2781443005: Remove unnecessary calls to std::basic_string<>::c_str() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index d20aa05375795737ea042cc6fdd18131eb6ba6db..177698b372d8d6313c00750c28287e18915feb12 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1789,7 +1789,7 @@ void TabsDetectLanguageFunction::Observe(

}

void TabsDetectLanguageFunction::GotLanguage(const std::string& language) {

- SetResult(base::MakeUnique<base::Value>(language.c_str()));

+ SetResult(base::MakeUnique<base::Value>(language));

SendResponse(true);

Release(); // Balanced in Run()

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_helpers.cc ('k') | no next file » | no next file with comments »