chrome/browser/extensions/api/preference/preference_helpers.cc - Issue 2781443005: Remove unnecessary calls to std::basic_string<>::c_str()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_helpers.cc

Issue 2781443005: Remove unnecessary calls to std::basic_string<>::c_str() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/preference/preference_helpers.cc

diff --git a/chrome/browser/extensions/api/preference/preference_helpers.cc b/chrome/browser/extensions/api/preference/preference_helpers.cc

index e2b3577cbe59298be11c837761513941770bfb5f..f180cdb79d49e4957b9046c1001ea87bda113fe6 100644

--- a/chrome/browser/extensions/api/preference/preference_helpers.cc

+++ b/chrome/browser/extensions/api/preference/preference_helpers.cc

@@ -61,8 +61,7 @@ const char* GetLevelOfControl(

: profile->GetPrefs();

bool from_incognito = false;

bool* from_incognito_ptr = incognito ? &from_incognito : NULL;

- const PrefService::Preference* pref =

- prefs->FindPreference(browser_pref.c_str());

+ const PrefService::Preference* pref = prefs->FindPreference(browser_pref);

CHECK(pref);

if (!pref->IsExtensionModifiable())