Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Issue 2780943002: Enables ScreenPinningController for mash/mus (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enables ScreenPinningController for mash/mus And removes unnecessary code in WmShell/WmWindow. BUG=622486 TEST=covered by tests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2780943002 Cr-Commit-Position: refs/heads/master@{#460399} Committed: https://chromium.googlesource.com/chromium/src/+/1385715e4bbb9aa74264578e5dba49890c49c12d

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : local #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -80 lines) Patch
M ash/BUILD.gn View 4 chunks +2 lines, -6 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/wm/default_state.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_state.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/common/wm/overview/window_selector_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/common/wm/window_cycle_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager.cc View 1 2 5 chunks +6 lines, -4 lines 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/wm_shell.h View 1 chunk +0 lines, -12 lines 0 comments Download
M ash/common/wm_window.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/wm_window.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/screen_pinning_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/screen_pinning_controller_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
sky
3 years, 8 months ago (2017-03-28 23:05:27 UTC) #1
msw
lgtm https://codereview.chromium.org/2780943002/diff/20001/ash/common/wm/workspace/workspace_layout_manager.cc File ash/common/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/2780943002/diff/20001/ash/common/wm/workspace/workspace_layout_manager.cc#newcode324 ash/common/wm/workspace/workspace_layout_manager.cc:324: if (!Shell::Get()->screen_pinning_controller()->IsPinned() && optional nit: cache value in ...
3 years, 8 months ago (2017-03-29 00:07:41 UTC) #4
sky
https://codereview.chromium.org/2780943002/diff/20001/ash/common/wm/workspace/workspace_layout_manager.cc File ash/common/wm/workspace/workspace_layout_manager.cc (right): https://codereview.chromium.org/2780943002/diff/20001/ash/common/wm/workspace/workspace_layout_manager.cc#newcode324 ash/common/wm/workspace/workspace_layout_manager.cc:324: if (!Shell::Get()->screen_pinning_controller()->IsPinned() && On 2017/03/29 00:07:41, msw wrote: > ...
3 years, 8 months ago (2017-03-29 02:40:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780943002/40001
3 years, 8 months ago (2017-03-29 02:41:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 04:42:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2780943002/40001
3 years, 8 months ago (2017-03-29 15:40:41 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 15:46:54 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1385715e4bbb9aa74264578e5dba...

Powered by Google App Engine
This is Rietveld 408576698