content/shell/test_runner/web_frame_test_client.cc - Issue 2779893006: Remove WebLocalFrame* from didReceiveServerRedirectForProvisionalLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/web_frame_test_client.cc

Issue 2779893006: Remove WebLocalFrame* from didReceiveServerRedirectForProvisionalLoad (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/web_frame_test_client.cc

diff --git a/content/shell/test_runner/web_frame_test_client.cc b/content/shell/test_runner/web_frame_test_client.cc

index 35f8fdb650e61373cf270745b195f64ef4f91278..a98bf986ca033144d72d02ee12a5b3218a679f43 100644

--- a/content/shell/test_runner/web_frame_test_client.cc

+++ b/content/shell/test_runner/web_frame_test_client.cc

@@ -436,11 +436,9 @@ void WebFrameTestClient::didStartProvisionalLoad(

}

-void WebFrameTestClient::didReceiveServerRedirectForProvisionalLoad(

- blink::WebLocalFrame* frame) {

- DCHECK_EQ(frame, web_frame_test_proxy_base_->web_frame());

+void WebFrameTestClient::didReceiveServerRedirectForProvisionalLoad() {

if (test_runner()->shouldDumpFrameLoadCallbacks()) {

- PrintFrameDescription(delegate_, frame);

+ PrintFrameDescription(delegate_, web_frame_test_proxy_base_->web_frame());

delegate_->PrintMessage(

" - didReceiveServerRedirectForProvisionalLoadForFrame\n");

}